| 24 Feb 2024 |
 Pol | tgerbet: Do you have a clue of a meaningful variable name for that? | 14:51:10 |
| Pol | dontComposerDownload? | 14:51:18 |
| Pol | requireComposerDependencies ? | 14:51:33 |
| Pol | I have absolutely no clue for such a good variable name? | 14:51:58 |
| Pol | * I have absolutely no clue for such a good variable name... | 14:52:00 |
 tgerbet | `dontRequireComposerDependencies`? | 14:58:29 |
| tgerbet | The "dont" should probably be present since it's going to be enabled by default | 15:00:04 |
| Pol | Ok let's go with that one. | 15:01:02 |
| Pol | tgerbet: I've removed that feature for the moment, I'll postpone it at another moment... and to be honest, I don't know if it is really required | 17:52:43 |
| 25 Feb 2024 |
| Pol | tgerbet: I've made the most recent bumps in the PR, removed the features we discussed, everything is clean now. | 09:13:20 |
| Pol | * tgerbet: I've made new commits to bump to the most recent version in the PR, removed the features we discussed (it's actually not needed now), everything is clean now, ready for review. | 09:13:50 |
| Pol | I will have limited availability on the computer next week, I finally take some days off, to Sardinia! | 09:14:24 |
| Pol | Ciao a tutti | 09:14:27 |
| tgerbet | Enjoy your days off 👋 | 10:33:31 |
 @patka_123:matrix.org | Have a nice holiday Pol ! | 10:57:08 |
| 29 Feb 2024 |
 w | Guys I need some help ☹️ | 20:04:53 |
| w | In reply to @wjjunyor:matrix.org
Guys I need some help ☹️ error: syntax error, unexpected '=', expecting ')'
at /etc/nixos/wordpress-configuration.nix:14:23:
13| nixpkgs.overlays = [ (self: super:
14| wordpressPackages = builtins.fetchGit {
| ^
15| url = "https://git.helsinki.tools/helsinki-systems/wp4nix";
| 20:05:23 |
| w | In reply to @wjjunyor:matrix.org
Guys I need some help ☹️ I just doesn't get this overlay thing proprly | 20:06:50 |
| Pol | Can you post your configuration somewhere? | 21:52:08 |
| 1 Mar 2024 |
| w | In reply to @drupol:matrix.org
Can you post your configuration somewhere? https://github.com/wjjunyor/pegasus | 02:52:19 |
 etu | I just wanted to report that the new php-codesniffer package doesn't build on PHP 8.1, some dependency says that it doesn't work there :) | 08:44:37 |
| etu | So it could be marked as broken in the meta attribute in the derivation to catch it earlier :) | 08:45:15 |
| tgerbet | Hum maybe we should the require-dev section in the composer.json in composerInstallBuildHook when composerNoDev is true | 08:55:26 |
| tgerbet | * Hum maybe we should remove the require-dev section in the composer.json in composerInstallBuildHook when composerNoDev is true | 08:55:50 |
| tgerbet | Dropping the require-dev in the composer.json and setting packages-dev to [] in the composer.lock seems to work
Running nixpkgs-review on it and submitting it to review
| 09:21:25 |
| tgerbet | Redacted or Malformed Event | 09:37:35 |
| tgerbet | In reply to @wjjunyor:matrix.org
https://github.com/wjjunyor/pegasus Try with something looking like this
diff --git a/wordpress-configuration.nix b/wordpress-configuration.nix
index 04805bc..54eceb1 100644
--- a/wordpress-configuration.nix
+++ b/wordpress-configuration.nix
@@ -10,13 +10,13 @@
environment.systemPackages = with pkgs; [ wp4nix php ];
environment.variables.WP_VERSION = "6.4";
- nixpkgs.overlays = [ (self: super:
- wordpressPackages {
- src = builtins.fetchGit {
+ nixpkgs.overlays = [
+ (self: super: {
+ wordpressPackages = builtins.fetchGit {
url = "https://git.helsinki.tools/helsinki-systems/wp4nix";
ref = "master";
};
- }
- )];
+ })
+ ];
}
| 09:38:03 |
| tgerbet | In reply to @tgerbet:matrix.org
Dropping the require-dev in the composer.json and setting packages-dev to [] in the composer.lock seems to work
Running nixpkgs-review on it and submitting it to review
https://github.com/NixOS/nixpkgs/pull/292508 | 09:44:31 |
| @patka_123:matrix.org | In the PR description it says fixes the build, but on the bottom it says failed to build codesniffer in the nixpkgs-review output | 09:50:32 |
| tgerbet | php-cs-fixer !== php-codesniffer :) | 09:51:31 |
