| 19 Feb 2024 |
Pol | * In Nix, when building a PHP derivation, the .git folder doesn't exist, therefore Composer is not able to infer the version... and it fails. SettingCOMPOSER\_ROOT\_VERSION fix that. | 21:06:23 |
Pol | * In Nix, when building a PHP derivation, the .git folder doesn't exist, therefore Composer is not able to infer the version... and it fails. SettingCOMPOSER_ROOT_VERSION fix that. | 21:06:30 |
Pol | patka, tgerbet , Gaƫl Reyrol : I'm looking for reviewers on this: https://github.com/NixOS/nixpkgs/pull/285828 | 21:37:28 |
@patka_123:matrix.org | I'll just be honest, I probably don't have the means to review this properly the coming few days | 22:21:52 |
| 20 Feb 2024 |
Pol | Totally fine, it's just open-source, we do what we can do at our best effort :) no worries! Hope everything's fine though. | 10:33:09 |
Pol | Oh damn... I've broken my pants in https://github.com/NixOS/nixpkgs/pull/285828 | 11:45:33 |
Pol | I upgraded a couple of derivations and switch to using buildComposerProject wrapper | 11:45:50 |
Pol | I hope it's ok to do that into that PR. | 11:45:57 |
Pol | Once this PR will be merged, there will be only one PHAR in Nix: Composer (only used to bootstrap Composer sources) | 21:59:37 |
Pol | * Once this PR will be merged, there will be only one PHAR in Nixpkgs: Composer (only used to bootstrap Composer sources) | 21:59:46 |
| 21 Feb 2024 |
Pol | I'm still looking for reviewers at https://github.com/NixOS/nixpkgs/pull/285828 ! :) | 19:32:31 |
tgerbet | I will try to take a look but it's unlikely to happen before this week end | 21:18:45 |
Pol | Okidocky | 21:50:08 |
| 23 Feb 2024 |
Pol | Oh yeah ! The Composer bug we have with 2.7.0 has been flagged as a bug by Jordi! | 11:19:36 |
Pol | Link: https://github.com/composer/composer/pull/11850 | 11:19:39 |
Pol | Also, this PR has been merged this morning: https://github.com/composer/composer/pull/11858 | 11:20:00 |
Pol | Issue fixed in Composer ! \o/ https://github.com/composer/composer/pull/11850 | 13:20:11 |
Pol | I'll update the PR when 2.7.2 will be out. | 13:23:55 |
| 24 Feb 2024 |
Pol | tgerbet: Do you have a clue of a meaningful variable name for that? | 14:51:10 |
Pol | dontComposerDownload? | 14:51:18 |
Pol | requireComposerDependencies ? | 14:51:33 |
Pol | I have absolutely no clue for such a good variable name? | 14:51:58 |
Pol | * I have absolutely no clue for such a good variable name... | 14:52:00 |
tgerbet | `dontRequireComposerDependencies`? | 14:58:29 |
tgerbet | The "dont" should probably be present since it's going to be enabled by default | 15:00:04 |
Pol | Ok let's go with that one. | 15:01:02 |
Pol | tgerbet: I've removed that feature for the moment, I'll postpone it at another moment... and to be honest, I don't know if it is really required | 17:52:43 |
| 25 Feb 2024 |
Pol | tgerbet: I've made the most recent bumps in the PR, removed the features we discussed, everything is clean now. | 09:13:20 |
Pol | * tgerbet: I've made new commits to bump to the most recent version in the PR, removed the features we discussed (it's actually not needed now), everything is clean now, ready for review. | 09:13:50 |
Pol | I will have limited availability on the computer next week, I finally take some days off, to Sardinia! | 09:14:24 |