Nix PHP | 76 Members | |
| A room for PHP developers running on Nix | 22 Servers |
| Sender | Message | Time |
|---|---|---|
| 13 Feb 2024 | ||
| But first, I need to bisect it so I can show which commit broke it. | 16:12:03 | |
| The issue is in between 2.6.6 and 2.7.0 | 16:14:06 | |
I have a hunch, a gut feeling that tells me that this might be the issue: * Fixed update --lock not keeping the dist reference/url/checksum pinned (#11787) | 16:15:44 | |
| Not sure yet. | 16:15:45 | |
| 16:47:53 | |
| Right... we have the guilty commit. | 16:48:13 | |
| Now I have to make a clean proof of concept issue to submit to Composer guys | 16:48:31 | |
| Job done: https://github.com/composer/composer/pull/11850 | 18:32:57 | |
| Feeeew | 18:33:00 | |
| I hope there will be a good outcome of this issue | 20:41:22 | |
| If I have time and energy tomorrow I'll have a look into it because it seems interesting. Good job on the work! | 20:42:55 | |
| Thanks :) | 20:45:42 | |
| 14 Feb 2024 | ||
| I hope we won't have to recalculate the hash of all PHP derivations :S | 07:43:30 | |
| I hope not. But I can help with that and I guess it would just take a few hours at most | 08:03:18 | |
| Yeah I might need a bit of help on this | 08:04:10 | |
| I'm curious to know if the proposed fix is appropriate | 08:04:22 | |
| So basically, this commit: https://github.com/composer/composer/pull/11850/commits/68e1ac0c3a2f61b8e711896bca8a40da09719e8d | 08:04:37 | |
| The idea is to let composer update those values if they hasn't been changed in the meantime. | 08:11:09 | |
| 15 Feb 2024 | ||
| I'm looking for a review here (very easy): https://github.com/NixOS/nixpkgs/pull/289146 | 21:29:09 | |
| PHP bump available: https://github.com/NixOS/nixpkgs/pull/289138 | 22:26:16 | |
| 16 Feb 2024 | ||
| I have always done what philipp said. Having php picked up from PATH might work in theory but that breaks composer working without php on PATH (not sure how common that is) | 07:29:56 | |
| (well, we could have an executable that tries php from PATH, falling back to a hardcoded one but IME, this kiind of magic often leads to confusion) | 07:32:23 | |
| 17 Feb 2024 | ||
| I wrote about dealing with private packages: https://stephank.nl/p/2024-02-17-using-nix-flake-inputs-with-php-composer.html | 20:43:41 | |
In reply to @stephank:stephank.nlMassive ! | 21:09:45 | |
| Nicely written! :D | 21:42:15 | |
In reply to @drupol:matrix.org
I think you could set | 23:10:10 | |
| 18 Feb 2024 | ||
In reply to @drupol:matrix.orgThat only sets the version of the root, but I'm trying to fix a dependency version. Maybe it does work, though, because it should also affect packages in subdirs? Depends on if Composer resolves the symlinks I create in .flake-inputs. But also, it'd set everything to the same version, which wouldn't work in my case. Multiple packages versioned separately. | 07:33:30 | |
| It would be nice to have that in the nix documentation | 07:35:36 | |
| Given this trivial derivation:
Anybody has a clue on how I could see that a patch has been applied when generated the SBOM of the derivation? To generate the SBOM, I use: https://github.com/nikstur/bombon The odd thing is that I can see patches in the SBOM for other derivations, but not for PHP. Do you have a lead, a clue, a suggestion? | 10:08:09 | |
| Same stuff with Composer which is currently patched for security at https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/php-packages/composer/default.nix | 10:15:14 | |