| 13 Feb 2024 |
Pol | Let me spawn a shell with nixpkgs-review and I'll let you know | 14:44:00 |
Pol | shit it's failing everywhere. | 15:00:41 |
Pol | #investigating | 15:07:20 |
Pol | I don't understand, it's failing on composer/ca-bundle, I don't know yet where it comes form | 15:11:55 |
Pol | I will reproduce the issue at home and open an issue at composer/composer I guess... | 15:26:49 |
Pol | * I will reproduce the issue without Nix at home and open an issue at composer/composer I guess... | 15:27:00 |
Pol | Issue identified! | 15:29:54 |
Pol | It's in https://github.com/nix-community/composer-local-repo-plugin | 15:30:11 |
Pol | For some reason, some references are still refering Git instead of a local path | 15:30:25 |
Pol | Oh no. | 15:30:54 |
Pol | False alarm. | 15:30:57 |
@patka_123:matrix.org | I'm on the road now so can't do much. But there's something in the release notes about plugins
https://github.com/composer/composer/releases/tag/2.7.0 | 15:42:30 |
Pol | I can't reproduce it locally :S https://gist.github.com/drupol/ab25340ea5fa46e3c2f49c1d9ed5eb71 | 15:43:43 |
Pol | I will bisect properly from home... | 15:44:53 |
Pol | If you want to help, I just published the shell script that I use to test | 15:47:57 |
Pol | This is basically replicating what pkgs.php.buildComposerProject {} is doing. | 15:48:16 |
Pol | Ok I can reproduce it locally now :) | 16:11:01 |
Pol | I will post the issue on composer/composer ! | 16:11:08 |
Pol | But first, I need to bisect it so I can show which commit broke it. | 16:12:03 |
Pol | The issue is in between 2.6.6 and 2.7.0 | 16:14:06 |
Pol | I have a hunch, a gut feeling that tells me that this might be the issue: * Fixed update --lock not keeping the dist reference/url/checksum pinned (#11787) | 16:15:44 |
Pol | Not sure yet. | 16:15:45 |
Pol | ❯ git bisect bad
042a8c212801aeac42b7a41b42cd1185ae28123a is the first bad commit
commit 042a8c212801aeac42b7a41b42cd1185ae28123a
Author: Jordi Boggiano <j.boggiano@seld.be>
Date: Wed Jan 10 13:33:49 2024 +0100
Ensure dist url/type/checksum remain the same when doing lock hash updates, refs #11787
src/Composer/DependencyResolver/LockTransaction.php | 3 +++
1 file changed, 3 insertions(+)
~/C/d/composer > 042a8c2(BISECTING) > php ❯
| 16:47:53 |
Pol | Right... we have the guilty commit. | 16:48:13 |
Pol | Now I have to make a clean proof of concept issue to submit to Composer guys | 16:48:31 |
Pol | Job done: https://github.com/composer/composer/pull/11850 | 18:32:57 |
Pol | Feeeew | 18:33:00 |
Pol |
I hope there will be a good outcome of this issue | 20:41:22 |
@patka_123:matrix.org | If I have time and energy tomorrow I'll have a look into it because it seems interesting. Good job on the work! | 20:42:55 |
Pol | Thanks :) | 20:45:42 |