!jngDrdMgndWibPCYsR:nixos.org

Nix PHP

76 Members
A room for PHP developers running on Nix22 Servers

Load older messages


SenderMessageTime
6 Feb 2024
@drupol:matrix.orgPolhttps://github.com/NixOS/nixpkgs/actions/runs/7806376986/job/21292605678?pr=28681621:33:16
@patka_123:matrix.org@patka_123:matrix.orgYeah I saw that. Fixing it now :)21:36:08
@drupol:matrix.orgPolBeside that, all good !21:36:40
@patka_123:matrix.org@patka_123:matrix.orgDone21:43:33
@drupol:matrix.orgPolI'll merge it when tests are green21:47:09
@drupol:matrix.orgPolThanks for it!21:47:32
@patka_123:matrix.org@patka_123:matrix.orgThanks so far! Have a nice evening21:48:17
@drupol:matrix.orgPolYou too ! Bye!21:50:16
@patka_123:matrix.org@patka_123:matrix.org
In reply to @drupol:matrix.org
Let's see how they are going to react with this: https://github.com/Smile-SA/gdpr-dump/issues/95
I was thinking for two whole seconds to do this for Pest as well. But I know the answer I'm going to get and don't feel like wasting energy on it
22:02:57
@drupol:matrix.orgPol
In reply to @patka_123:matrix.org
I was thinking for two whole seconds to do this for Pest as well. But I know the answer I'm going to get and don't feel like wasting energy on it
Please do it, but I won't!
22:04:20
@drupol:matrix.orgPol
In reply to @patka_123:matrix.org
I was thinking for two whole seconds to do this for Pest as well. But I know the answer I'm going to get and don't feel like wasting energy on it
https://github.com/php-parallel-lint/PHP-Parallel-Lint/issues/153 that issue makes we want to reconsider adding composer.lock in nixpkgs 
22:06:49
7 Feb 2024
@patka_123:matrix.org@patka_123:matrix.orgThat is a good explanation of why a lot of projects don't provide a composer.lock. The FOSS packages we maintain at $work also don't have a lock05:08:45
@patka_123:matrix.org@patka_123:matrix.org
In reply to @drupol:matrix.org
https://github.com/php-parallel-lint/PHP-Parallel-Lint/issues/153 that issue makes we want to reconsider adding composer.lock in nixpkgs 

I don't understand this. Putting a package under by-name is done for applications, so there you want a lock file. The application is the "end user" and thus decides all versions.

If you have some kind of library that might be a dependency elsewhere then the package should be in something like php83. and you still want a lock file.

We can't magically figure out at runtime which dependencies to build if there is no lockfile.

06:05:55
@patka_123:matrix.org@patka_123:matrix.orgOr am I missing something?06:06:15
@etu:failar.nuetu
In reply to @drupol:matrix.org
Elis 🌱: Have a look at how Rector is packaged... https://github.com/rectorphp/rector
Yeah... I mean... it's one way :D
06:12:03
@patka_123:matrix.org@patka_123:matrix.org
In reply to @drupol:matrix.org
Elis 🌱: Have a look at how Rector is packaged... https://github.com/rectorphp/rector

To me it makes sense. They are just "vendoring" their dependencies so they provide all dependencies for you already.

Unless you override it the dictate the exact dependencies. This seems to me the most reproducible way, isn't it?

06:18:45
@patka_123:matrix.org@patka_123:matrix.org
In reply to @drupol:matrix.org
Elis 🌱: Have a look at how Rector is packaged... https://github.com/rectorphp/rector
*
06:34:29
@drupol:matrix.orgPol
In reply to @patka_123:matrix.org

I don't understand this. Putting a package under by-name is done for applications, so there you want a lock file. The application is the "end user" and thus decides all versions.

If you have some kind of library that might be a dependency elsewhere then the package should be in something like php83. and you still want a lock file.

We can't magically figure out at runtime which dependencies to build if there is no lockfile.

Composer.lock should be available if and only if the package you're shipping is meant to be an application. 
08:00:03
@drupol:matrix.orgPol
In reply to @patka_123:matrix.org
To me it makes sense. They are just "vendoring" their dependencies so they provide all dependencies for you already. Unless you override it they dictate the exact dependencies. This seems to me the most reproducible way, isn't it?
The vendor dir is incomplete. That's the funny part !
08:00:39
@drupol:matrix.orgPol Jan Tojnar: Do you think it's ready to merge? https://github.com/fossar/nix-phps/pull/321 08:21:21
@patka_123:matrix.org@patka_123:matrix.org

Who can make issue labels for nixpkgs? Every language seems to have a "6.topic: java" like tag.

But there's none for php

11:07:07
@drupol:matrix.orgPol
In reply to @drupol:matrix.org
Let's see how they are going to react with this: https://github.com/Smile-SA/gdpr-dump/issues/95
Feel free to add your +1 and comments!
11:07:19
@patka_123:matrix.org@patka_123:matrix.orgAnd is there anything (that's not too difficult) I can help with? I can't find any open packaging requests for php11:08:47
@patka_123:matrix.org@patka_123:matrix.org
In reply to @drupol:matrix.org
Feel free to add your +1 and comments!
I'm still not sure if I agree. It can be installed with Composer and it states that it supports multiple php versions. They would also have a valid reason to not include a lock file
11:11:55
@drupol:matrix.orgPol If they produce a PHAR, that means that they have the composer.lock that works ! https://github.com/Smile-SA/gdpr-dump/releases/tag/4.0.3 11:12:50
@drupol:matrix.orgPolThat means that they can ship it.11:12:58
@drupol:matrix.orgPol
In reply to @patka_123:matrix.org
And is there anything (that's not too difficult) I can help with? I can't find any open packaging requests for php
There are no package request AFAIK... however, there's a bug that might need some investigations here: https://github.com/NixOS/nixpkgs/issues/281584
11:14:42
@drupol:matrix.orgPolAnd if you want to fulfill package requests: https://github.com/NixOS/nixpkgs/issues/28037411:15:39
@drupol:matrix.orgPolAnother easy one: https://github.com/NixOS/nixpkgs/issues/26214211:17:44
@patka_123:matrix.org@patka_123:matrix.org
In reply to @drupol:matrix.org
If they produce a PHAR, that means that they have the composer.lock that works ! https://github.com/Smile-SA/gdpr-dump/releases/tag/4.0.3

The phar just means that they also distribute an end user application.

If I have a work project and decide to use their tool and use composer for that I'd want to choose my own versions (or at least their their lock is accommodating enough).

So from their POV you can still make a valid case that a lock is not needed. And only useful if you create an end user application (which we do for nixpkgs so we can generate it ourselves)

11:19:12

Show newer messages


Back to Room ListRoom Version: 6