Nix PHP | 76 Members | |
| A room for PHP developers running on Nix | 22 Servers |
| Sender | Message | Time |
|---|---|---|
| 6 Feb 2024 | ||
| https://github.com/NixOS/nixpkgs/actions/runs/7806376986/job/21292605678?pr=286816 | 21:33:16 | |
| Yeah I saw that. Fixing it now :) | 21:36:08 | |
| Beside that, all good ! | 21:36:40 | |
| Done | 21:43:33 | |
| I'll merge it when tests are green | 21:47:09 | |
| Thanks for it! | 21:47:32 | |
| Thanks so far! Have a nice evening | 21:48:17 | |
| You too ! Bye! | 21:50:16 | |
In reply to @drupol:matrix.orgI was thinking for two whole seconds to do this for Pest as well. But I know the answer I'm going to get and don't feel like wasting energy on it | 22:02:57 | |
In reply to @patka_123:matrix.orgPlease do it, but I won't! | 22:04:20 | |
In reply to @patka_123:matrix.orghttps://github.com/php-parallel-lint/PHP-Parallel-Lint/issues/153 that issue makes we want to reconsider adding composer.lock in nixpkgs | 22:06:49 | |
| 7 Feb 2024 | ||
| That is a good explanation of why a lot of projects don't provide a composer.lock. The FOSS packages we maintain at $work also don't have a lock | 05:08:45 | |
In reply to @drupol:matrix.org I don't understand this. Putting a package under by-name is done for applications, so there you want a lock file. The application is the "end user" and thus decides all versions. If you have some kind of library that might be a dependency elsewhere then the package should be in something like php83. and you still want a lock file. We can't magically figure out at runtime which dependencies to build if there is no lockfile. | 06:05:55 | |
| Or am I missing something? | 06:06:15 | |
In reply to @drupol:matrix.orgYeah... I mean... it's one way :D | 06:12:03 | |
In reply to @drupol:matrix.org To me it makes sense. They are just "vendoring" their dependencies so they provide all dependencies for you already. Unless you override it the dictate the exact dependencies. This seems to me the most reproducible way, isn't it? | 06:18:45 | |
In reply to @drupol:matrix.org* | 06:34:29 | |
In reply to @patka_123:matrix.orgComposer.lock should be available if and only if the package you're shipping is meant to be an application. | 08:00:03 | |
In reply to @patka_123:matrix.orgThe vendor dir is incomplete. That's the funny part ! | 08:00:39 | |
| Jan Tojnar: Do you think it's ready to merge? https://github.com/fossar/nix-phps/pull/321 | 08:21:21 | |
| Who can make issue labels for nixpkgs? Every language seems to have a "6.topic: java" like tag. But there's none for php | 11:07:07 | |
In reply to @drupol:matrix.orgFeel free to add your +1 and comments! | 11:07:19 | |
| And is there anything (that's not too difficult) I can help with? I can't find any open packaging requests for php | 11:08:47 | |
In reply to @drupol:matrix.orgI'm still not sure if I agree. It can be installed with Composer and it states that it supports multiple php versions. They would also have a valid reason to not include a lock file | 11:11:55 | |
If they produce a PHAR, that means that they have the composer.lock that works ! https://github.com/Smile-SA/gdpr-dump/releases/tag/4.0.3 | 11:12:50 | |
| That means that they can ship it. | 11:12:58 | |
In reply to @patka_123:matrix.orgThere are no package request AFAIK... however, there's a bug that might need some investigations here: https://github.com/NixOS/nixpkgs/issues/281584 | 11:14:42 | |
| And if you want to fulfill package requests: https://github.com/NixOS/nixpkgs/issues/280374 | 11:15:39 | |
| Another easy one: https://github.com/NixOS/nixpkgs/issues/262142 | 11:17:44 | |
In reply to @drupol:matrix.org The phar just means that they also distribute an end user application. If I have a work project and decide to use their tool and use composer for that I'd want to choose my own versions (or at least their their lock is accommodating enough). So from their POV you can still make a valid case that a lock is not needed. And only useful if you create an end user application (which we do for nixpkgs so we can generate it ourselves) | 11:19:12 | |