| 5 Feb 2024 |
 Shyim | Pol: I think we just need to provide brotli in the buildInputs 🤔 | 09:29:08 |
| Shyim | Pol: here is an PR :D https://github.com/NixOS/nixpkgs/pull/286457 | 09:42:34 |
 Pol | Merci <3 | 09:47:44 |
| Pol | Closing other 2 PRs | 09:47:53 |
| Pol | Oh finally! After 3 days :D
❯ git bisect good
1e8bba4d5dadc087a8d53f131af2bb2505e663d8 is the first bad commit
commit 1e8bba4d5dadc087a8d53f131af2bb2505e663d8
Author: Yureka <yuka@yuka.dev>
Date: Thu Jan 11 12:33:48 2024 +0100
libjxl: build with openexr 3 (#279947)
pkgs/development/libraries/libjxl/default.nix | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
| 15:25:00 |
| Pol | @Elis 🌱 It's finally ready for review: https://github.com/NixOS/nixpkgs/pull/285828 | 20:23:04 |
|  getbygenius joined the room. | 23:17:40 |
| 6 Feb 2024 |
| Pol | Elis 🌱: Have a look at how Rector is packaged... https://github.com/rectorphp/rector | 17:24:15 |
| Pol | They ship the vendor dir... | 17:24:21 |
| Pol | Jan Tojnar: I found the problematic issue with PHP 5.6 | 17:29:12 |
| Pol | After 5 days of bisecting | 17:29:20 |
| Pol | ❯ git bisect bad
Bisecting: 0 revisions left to test after this (roughly 0 steps)
[62abc91b9fa2bd651bb7bb0a7f7fecb9285130c0] autoconf: 2.71 -> 2.72
| 17:29:21 |
| Pol | Arch people have the issue as well: https://aur.archlinux.org/packages/php56-ldap?all_deps=1 | 17:34:21 |
| Pol | I don't know how to fix this properly since the file configure gets created after phpize I believe. | 17:38:14 |
| Pol | Got the fix ! | 17:51:51 |
| Pol | Fix: https://github.com/fossar/nix-phps/pull/321/commits/c0366ec6e614211d498f1cb0c29f8d55341e47ae | 17:58:53 |
 Jan Tojnar | Nice, good job! | 19:02:32 |
|  @patka_123:matrix.org joined the room. | 20:33:45 |
| @patka_123:matrix.org | Hello 👋
I'm new to nixpkgs and just started contributing recently. Since my work is doing PHP I thought I'd start here :) | 20:38:13 |
| Pol | Welcome ! | 20:39:30 |
| @patka_123:matrix.org | I thought since phpunit is already packaged, I might as well package Pest :D | 20:51:26 |
| @patka_123:matrix.org | * I thought since phpunit is already packaged I might as well package Pest :D | 20:52:56 |
| Pol | You're free to do it indeed | 20:59:39 |
| Pol | Even if I have my own personal opinion on some frameworks, Nix is not here to judge or anything. If you want to provide it in Nix, got for it. | 21:00:13 |
| Pol | The more package we have, the more likely Nix is going to be adopted by many people. | 21:00:29 |
| @patka_123:matrix.org | I also have pretty strong personal opinions about certain frameworks and even about PHP itself ^^ I'm not a fan of Pest at all. But it is pretty big so it'd be good to have that packaged regardless :) | 21:04:46 |
| Pol | Likewise. | 21:06:40 |
| Pol | send your PR and I'll review it. | 21:06:49 |
| Pol | A fresh PR I just made where you can get some inspiration: https://github.com/NixOS/nixpkgs/pull/286809 | 21:07:08 |
| Pol | Let's see how they are going to react with this: https://github.com/Smile-SA/gdpr-dump/issues/95 | 21:08:16 |
