| 1 Feb 2024 |
 Pol | * I just pushed a commit to use the patch from github:php/php-src. | 17:28:55 |
 Jan Tojnar | Not a huge fan of the ellipsis, maybe removeAttrs fetchpatch from _attrs | 17:36:38 |
| Jan Tojnar | We can probably ignore soap for now since it is non-fatal | 17:39:04 |
| Pol | Right | 17:39:28 |
| Jan Tojnar | But it should be as easy as adding `patches = php.unwrapped.patches or [] ++ args.patches or []` to `mkExtension` in `php-packages.nix` | 17:42:05 |
| Pol | I removed the ellipsis | 17:43:27 |
| Pol | Now, what's left in there? | 17:43:52 |
| Pol | Jan Tojnar: Are you ok with this one ? https://github.com/NixOS/nixpkgs/pull/285511 | 18:32:35 |
| Jan Tojnar | In reply to @drupol:matrix.org
Jan Tojnar: Are you ok with this one ? https://github.com/NixOS/nixpkgs/pull/285511 Not really for me to decide, Nixpkgs PHP maintainers will bear the cost of extra code not needed for Nixpkgs | 18:53:22 |
| Pol | Ok but since I will most probably manage that, ... | 19:05:34 |
| Pol | I guess it's ok if I merge it ? | 19:05:40 |
| Jan Tojnar | In that case, it is probably fine. Just note that in the past, we have always cleaned references to PHP versions not available in Nixpkgs. Hence the common use of `builtins.filter` in nix-phps | 19:18:11 |
| Pol | Right let's do that. | 19:18:58 |
| 2 Feb 2024 |
| Pol | Elis 🌱: For you: https://github.com/NixOS/nixpkgs/pull/285828 | 15:58:15 |
| Pol | Redacted or Malformed Event | 16:03:48 |
| Pol | Asking for a repository composer.lock is sometimes successful, sometimes not... https://github.com/php-parallel-lint/PHP-Parallel-Lint/issues/153 | 18:09:03 |
 @etu:failar.nu | In reply to @drupol:matrix.org
Elis 🌱: For you: https://github.com/NixOS/nixpkgs/pull/285828 I'll look into it over the weekend :) | 18:17:37 |
| @etu:failar.nu | In reply to @drupol:matrix.org
Asking for a repository composer.lock is sometimes successful, sometimes not... https://github.com/php-parallel-lint/PHP-Parallel-Lint/issues/153 That's how collaboration across projects and teams tend to be, at least once something is big enough :) | 18:18:37 |
| Pol | I'm also looking for a way to make sur postPatch = '' '' ; works in the PHP/Composer builder, but I simply cannot get it to work. If you have a clue, it's very welcome | 21:26:52 |
| Pol | Please ignore my message, my brain farted. | 21:57:09 |
| 3 Feb 2024 |
| Pol | Do you have any idea on how I could avoid repeating myself in this commit: https://github.com/NixOS/nixpkgs/pull/285828/commits/e75a4765f0d99b97a16503be6a4e9a576b7ecc04 | 08:57:39 |
| Pol | I would like to have a single bash function for that | 08:57:56 |
| Pol | The good thing is that I finally found why COMPOSER_ROOT_VERSION was needed for vimeo/psalm ! | 08:58:47 |
| Pol | I can now automatically set it when needed :) | 08:58:54 |
| Pol | Elis 🌱: You're going to like the changes :D | 10:59:33 |
| Pol | Jan Tojnar: There's a new fancy issue while compiling php 5.6 at https://github.com/fossar/nix-phps/actions/runs/7768117423/job/21185685946?pr=321 | 17:04:23 |
| Jan Tojnar | Pol: lovely, can you send the content of configure script? | 17:06:12 |
| Pol | OK | 17:07:36 |
| Pol | re-running it locally and keeping the build dir. | 17:07:55 |
| Pol | Here we go: https://gist.github.com/drupol/6eddbd12f6ad107bfe94d02b4eeb0188 | 17:09:58 |
