| 25 Nov 2023 |
 Gaël Reyrol | * I didn't had enough time this week to go further. But one think is actually wrong, it is the way I fetch go modules, it is not reproducible and make the hash change between compilations. I have to fix this. Still the PR is published on nixpkgs but in draft mode. | 07:50:54 |
| Gaël Reyrol | https://github.com/NixOS/nixpkgs/pull/268665 | 07:51:26 |
 Pol | Nice, feel free to ping Kevin Dunglas in case of issue | 11:13:07 |
 w | In reply to @drupol:matrix.org
Are you using the function pkgs.php.buildComposerProject ? No. Just knew about it when I googled. I'll try it. | 12:43:14 |
| Gaël Reyrol | Sure, I need to fork the main repository and see if I can build his project with go vendor mod instead of relying on modules from the $GOPATH. | 13:45:49 |
| Gaël Reyrol | I mean, it is in fact possible but it misses an internal dependency that is not included in the vendor mod, it is a raw C library: https://github.com/dunglas/frankenphp/tree/main/C-Thread-Pool | 13:48:12 |
| Gaël Reyrol | turns out I just needed to enable vendorProxy = true; to fix this | 15:29:27 |
| Gaël Reyrol | I didn't knew about this in buildGoModule derivation | 15:29:42 |
| Gaël Reyrol | Last thing is to fix this pie mode, which require to use musl instead of glibc | 15:30:40 |
| Gaël Reyrol | * Last thing is to fix this pie buildmode, which require to use musl instead of glibc | 15:30:54 |
| Gaël Reyrol | Turns out that golang still do not include non go files when vendoring : https://github.com/golang/go/issues/26366 | 15:33:28 |
| Gaël Reyrol | * It is worth to mention that golang still do not include non go files when vendoring : https://github.com/golang/go/issues/26366 | 15:33:43 |
| Gaël Reyrol | I am not sure I want to try to compile it with musl, it will take ages 🤣 | 15:45:38 |
| Gaël Reyrol | Pol: the PR is ready to review :) | 15:52:50 |
| Pol | Il manque le mainProgram | 16:11:47 |
| Pol | Ah non sorry ! :) | 16:12:00 |
| Pol | c'est beau | 16:12:36 |
| Pol | I don't understand this part: https://github.com/NixOS/nixpkgs/pull/268665/files#diff-f50bfb682218622afd9adb8e68164f487edb707b2ae68e05ceb6504388b1f24cR75-R79 | 16:22:38 |
| Gaël Reyrol | This part allows to build a phpinfo page with Frankenphp as engine. Also if it fails, it means frankenphp is not properly working. | 16:42:53 |
| Gaël Reyrol | Try it: nix-build -A frankenphp.tests.phpinfo and open the result in your browser. | 16:43:18 |
| Gaël Reyrol | Pol: I reviewed my PR with some comments, I had some thoughts will taking a shower 😆 | 16:43:57 |
| Gaël Reyrol | * Pol: I reviewed my PR with some comments, I had some thoughts while taking a shower 😆 | 16:49:56 |
| Pol | About the buildInputs | 17:27:32 |
| Pol | Is it possible to do: | 17:27:40 |
| Pol | buildInputs = phpUnwrapped.buildInputs ++ [ pcre2 libargon2 libxml2 systemd ]; | 17:28:00 |
| Pol | * buildInputs = phpUnwrapped.buildInputs ++ [ pcre2 libargon2 libxml2 systemd ]; | 17:28:10 |
| Pol | Aaah you did it actually ! :D | 17:28:34 |
| Pol | Shower are always good :) | 17:29:55 |
| 27 Nov 2023 |
| Pol | Interesting discussion with Sebastian Bergmann regarding reproducibility: https://github.com/sebastianbergmann/phpunit/pull/5576#issuecomment-1827304401 | 07:54:33 |
| Pol | Especially this sentence:
And this is why: I do not think that PHPUnit should be installed using an operating system package manager.
| 07:54:50 |
