| 17 Nov 2023 |
 Gaël Reyrol | Hey Pol , about the renaming in this PR, should I also rename the derivation in php-packages ? It would break existing usage of php-spx even if it was not working ^^ | 12:08:29 |
 Pol | mmmh ok fair enough | 12:14:40 |
| Gaël Reyrol | What should I do then? | 14:49:34 |
| Gaël Reyrol | I have a small feedback on the composerInstallInstallHook, it collects bin files from the composer.json but let's imagine there is a script for Windows (for example a bat script). The makeWrapper will fail because it is not an executable, which is normal but I can prevent some project from being packaged. | 14:53:21 |
| Gaël Reyrol | * I have a small feedback on the composerInstallInstallHook, it collects bin files from the composer.json but let's imagine there is a script for Windows (for example a bat script). The makeWrapper will fail because it is not an executable, which is normal but it can prevent some project from being packaged. | 14:53:41 |
| Pol | There's room for improvements indeed. | 14:57:10 |
| Pol | Let's see what others are going to say | 14:57:22 |
| Pol | Did you had that specific problem with a package of yours? | 14:58:00 |
| Gaël Reyrol | fine :) | 14:58:05 |
| Gaël Reyrol | Yep, I need to package this old garbage : https://github.com/mentionapp/Protobuf-PHP | 14:58:52 |
| Gaël Reyrol | And the composer file contains a bat script in the bin : https://github.com/mentionapp/Protobuf-PHP/blob/master/composer.json#L15 | 14:59:24 |
| Gaël Reyrol | I thought it could happen on other projects too | 14:59:46 |
| Pol | Argh | 15:01:22 |
| Pol | I guess we should exclude files ending with .bat ! :) | 15:02:02 |
| Gaël Reyrol | That's what I thought 😁 | 15:05:07 |
| 18 Nov 2023 |
| Gaël Reyrol | 
Download Screenshot from 2023-11-18 17-09-11.png | 16:09:30 |
| Gaël Reyrol | If anyone is interested, I think I managed to package FrankenPHP, here is the derivation : https://github.com/gaelreyrol/nixpkgs/commit/7c0eb86b97877fa41c5c62591cdd3bb89bfd0ff3 :D | 16:09:33 |
| Pol | OMG ! I tried last month | 16:42:02 |
| Pol | How about submitting a PR against nixpkgs ? | 16:42:13 |
| Gaël Reyrol | I need to optimize a few things, add some real world tests and I will submit it :) | 16:54:45 |
| Pol | excellent ! | 17:22:55 |
| 19 Nov 2023 |
|  pbsds changed their display name from pbsds to pbsds (federation borken, may not see reply). | 03:35:28 |
|  ZXGU joined the room. | 11:02:40 |
| pbsds changed their display name from pbsds (federation borken, may not see reply) to pbsds. | 20:38:45 |
| 20 Nov 2023 |
 Shyim | Does it make sense that we use libphp.so with Frankenphp. So compile Frankenphp once and pass the libphp.so from that one needed php version 🤔. https://github.com/symfony-cli/symfony-cli/pull/216#issuecomment-1819813655 | 21:43:35 |
| Pol | Good question, I have no clue :S | 21:46:30 |
 Jan Tojnar | depends on whether different PHP versions promise stable ABI. I would not bet on it. | 22:19:32 |
| Jan Tojnar | (or if the consumer loads the symbols dynamically) | 22:20:19 |
| 21 Nov 2023 |
| Gaël Reyrol | Honestly I am not quite fan of the embedded thing that Kevin is trying to do with FrankenPHP, I don't think it is the responsibility of FrankenPHP to embed it, nor Apache and Nginx. It also adds a lot of compilation / cross compilation complexity , so maybe it is right way or a least a not so bad alternative. | 06:55:54 |
| Gaël Reyrol | * Honestly I am not quite fan of the embedded thing that Kevin is trying to do with FrankenPHP, I don't think it is the responsibility of FrankenPHP to embed it, nor Apache and Nginx. It also adds a lot of compilation / cross compilation complexity, so maybe it is right way or a least at not so bad alternative. | 07:00:10 |
