| 8 Sep 2023 |
 Pol | Feel free to add your voice to that PR, I really need it :) | 13:10:46 |
| Pol | Thanks to that PR, I can now provide this: https://github.com/fossar/nix-phps/pull/104#issuecomment-1711706025 | 13:58:18 |
| Pol | And a flake.nix for https://github.com/php/php-src ! :) | 13:58:32 |
| Pol | Got it working on my machine :) | 13:58:44 |
| Pol | => https://main.elk.zone/mathstodon.xyz/@Pol/111029255046941796 | 13:59:06 |
| 11 Sep 2023 |
| Pol | I just created a PR to update the PHP mkderivation wrapper in Nix: https://github.com/NixOS/nixpkgs/pull/254556, reviews are welcome | 13:13:47 |
| 13 Sep 2023 |
|  w joined the room. | 01:29:07 |
| Pol | I've created another PR here, it's about fossar/nix-phps, let me know what you think about the idea: https://github.com/fossar/nix-phps/pull/296 | 06:33:06 |
 etu | Pol: Should we try to do a final push on the new builder in nixpkgs? | 10:54:36 |
| etu | Asking people about the codeowner bit | 10:54:51 |
| * etu is fine to remain as codeowner for all php related files | 10:55:11 |
| Pol | Please raise that voice on the relevant PR, raitobezarius explicitly asked me to remove the PHP maintainers from the new stuff until it's not approved | 11:30:27 |
| Pol | Ho I see all the comments | 11:36:08 |
| etu | Yeah, I guess we can ask around quickly what people want since the PHP team haven't been touched in a long time | 11:40:14 |
| Pol | I think we should leave it as it is :) | 11:40:37 |
| Pol | And just add people who are manifesting some interests. | 11:40:47 |
| Pol | If you want to be added to the list, please make a quick commit, or I can do it for you if you can't do it now | 11:41:59 |
| etu | I'm thinking the current state is non-offensive, I just asked if the other person in the thread agrees | 11:44:37 |
| etu | Pol: I'm happily included in the codeowners file :) | 11:44:49 |
| Pol | Righty, should I do the commit or you want to do it yourself? (so Raito can see it in the PR that it comes from you) | 11:45:29 |
| etu | I have written a comment so you can add me if you like, I don't have a repo handy right here on the work laptop at the moment :) | 11:46:00 |
| etu | (nixos isn't work for me 😒) | 11:46:42 |
| etu | I want it to be, I guess, not sure how to make it so though. | 11:46:58 |
| Pol | Going to do it now! | 11:48:21 |
| etu | Jan Tojnar: You run wallabag right? I think I based my module on your config a while back. (my module https://github.com/etu/nixconfig/blob/main/modules/services/wallabag/default.nix ). Have you seen the breakage with the latest package update for it? I haven't solved it yet, the install systemd service has stopped working because it tries to include a PHP file from ../../<some name> where ../.. makes it end up in /nix/store 😂 | 11:50:31 |
| Pol | w00t | 12:37:13 |
| Pol | I'm looking for feedback on the following PRs:
- https://github.com/NixOS/nixpkgs/pull/254556
- https://github.com/fossar/nix-phps/pull/104
- https://github.com/fossar/nix-phps/pull/296
| 12:37:43 |
| 14 Sep 2023 |
| Pol | The PHP/Composer builder has been merged! https://github.com/NixOS/nixpkgs/pull/248184 | 07:11:15 |
| Pol | The first PR using the new builder is up ! https://github.com/NixOS/nixpkgs/pull/255122 | 16:06:47 |
| Pol | Elis 🌱: A bug has been reported here: https://github.com/NixOS/nixpkgs/pull/254817 I have the feeling that we will have the same issue with the PHP/Composer builder (https://github.com/NixOS/nixpkgs/blob/c5aab69eaafe229f15dc198eb8fde5f65e6c688b/pkgs/build-support/php/hooks/composer-install-hook.sh#L109) | 17:35:46 |
