| 8 Sep 2023 |
Pol | Lars Strojny: Now I will work on a PR to provide a flake.nix in the php/php-src source directly :) so we can have a CI that builds PHP at each commit ! | 05:01:49 |
Pol | And we are green ! https://github.com/fossar/nix-phps/pull/104 | 05:34:32 |
Pol | One year later :D | 05:34:35 |
Pol | php-master branch is building on Nix! https://github.com/fossar/nix-phps/pull/104 | 05:34:51 |
Pol | Someone to review this? https://github.com/NixOS/nixpkgs/pull/254001 | 10:17:31 |
Pol | Lars Strojny: I just made a flake.nix file for https://github.com/php/php-src that compile the master branch :) Works pretty fine !! Do you think it worth submitting a PR ? | 11:06:45 |
Pol | We could imagine also a default devShell that would provide all the tools needed for a PHP core developer :) | 11:07:23 |
Pol | We could imagine a Github action what would check if a commit is not breaking the builds ! :) | 11:14:36 |
Pol | Plenty of new possibilities !!! | 11:14:44 |
Pol | PR is green ^^ | 13:10:22 |
Pol | Feel free to add your voice to that PR, I really need it :) | 13:10:46 |
Pol | Thanks to that PR, I can now provide this: https://github.com/fossar/nix-phps/pull/104#issuecomment-1711706025 | 13:58:18 |
Pol | And a flake.nix for https://github.com/php/php-src ! :) | 13:58:32 |
Pol | Got it working on my machine :) | 13:58:44 |
Pol | => https://main.elk.zone/mathstodon.xyz/@Pol/111029255046941796 | 13:59:06 |
| 11 Sep 2023 |
Pol | I just created a PR to update the PHP mkderivation wrapper in Nix: https://github.com/NixOS/nixpkgs/pull/254556, reviews are welcome | 13:13:47 |
| 13 Sep 2023 |
| w joined the room. | 01:29:07 |
Pol | I've created another PR here, it's about fossar/nix-phps, let me know what you think about the idea: https://github.com/fossar/nix-phps/pull/296 | 06:33:06 |
@etu:failar.nu | Pol: Should we try to do a final push on the new builder in nixpkgs? | 10:54:36 |
@etu:failar.nu | Asking people about the codeowner bit | 10:54:51 |
| * @etu:failar.nu is fine to remain as codeowner for all php related files | 10:55:11 |
Pol | Please raise that voice on the relevant PR, raitobezarius explicitly asked me to remove the PHP maintainers from the new stuff until it's not approved | 11:30:27 |
Pol | Ho I see all the comments | 11:36:08 |
@etu:failar.nu | Yeah, I guess we can ask around quickly what people want since the PHP team haven't been touched in a long time | 11:40:14 |
Pol | I think we should leave it as it is :) | 11:40:37 |
Pol | And just add people who are manifesting some interests. | 11:40:47 |
Pol | If you want to be added to the list, please make a quick commit, or I can do it for you if you can't do it now | 11:41:59 |
@etu:failar.nu | I'm thinking the current state is non-offensive, I just asked if the other person in the thread agrees | 11:44:37 |
@etu:failar.nu | Pol: I'm happily included in the codeowners file :) | 11:44:49 |
Pol | Righty, should I do the commit or you want to do it yourself? (so Raito can see it in the PR that it comes from you) | 11:45:29 |