| 7 Sep 2023 |
 Pol | I've just rebased that branch, maybe Jan Tojnar if you could have a look? I have the feeling that the compilation goes further than last time... maybe I'm wrong, feel free to correct me. | 11:37:39 |
| Pol | I got it working... work in progres... | 14:16:39 |
| Pol | * I got it working... work in progress... | 14:16:42 |
| Pol | We are almost there actually. It seems that the tokenizer extension is failing to build, the rest looks pretty fine ! | 14:38:30 |
| Pol | Ok I give up... I'm a noob when it comes to yacc, bison, flex and makefiles. Do you know who could help on this? | 15:24:19 |
 Jan Tojnar | most of the older Nixpkgs contributors will be familiar with those tools but they will probably also be quite busy. Your best bet is probably asking on Discourse or main chat room and hoping someone can sacrifice an hour for digging into the PHP build system | 20:24:45 |
| Pol | I will post on discourse tomorrow. I'm trying to understand why it is so complex and what's the issue there. | 20:26:10 |
| Jan Tojnar | the makefile is generated by phpize, IIRC | 20:28:05 |
| Pol | yeah... is it an issue ? | 20:29:34 |
| Pol | I wrote my findings here: https://github.com/fossar/nix-phps/pull/104#issuecomment-1710320818 | 20:30:48 |
| Pol | Why there's no Makefile in the PHP distribution (in ext/tokenizer) | 20:31:21 |
| Pol | That is also something I'd like to understand | 20:31:30 |
| Pol | But since I never used those tools, it's complicated for me | 20:31:41 |
| Jan Tojnar | the lex error sounds like lex is missing some flag as well | 20:35:37 |
| Pol | These are RE2C_FLAGS ? | 20:37:01 |
| Pol | Have you seen this? https://github.com/php/php-src/blob/master/scripts/dev/genfiles | 20:45:00 |
| Pol | Maybe we should use it ? | 20:45:04 |
| Pol | GOT IT WORKING !!!! | 20:53:02 |
| Pol | Just pushed the change | 20:54:05 |
| Pol | Now going straigh to bed... | 20:55:38 |
| 8 Sep 2023 |
| Pol | Lars Strojny: Now I will work on a PR to provide a flake.nix in the php/php-src source directly :) so we can have a CI that builds PHP at each commit ! | 05:01:49 |
| Pol | And we are green ! https://github.com/fossar/nix-phps/pull/104 | 05:34:32 |
| Pol | One year later :D | 05:34:35 |
| Pol | php-master branch is building on Nix! https://github.com/fossar/nix-phps/pull/104 | 05:34:51 |
| Pol | Someone to review this? https://github.com/NixOS/nixpkgs/pull/254001 | 10:17:31 |
| Pol | Lars Strojny: I just made a flake.nix file for https://github.com/php/php-src that compile the master branch :) Works pretty fine !! Do you think it worth submitting a PR ? | 11:06:45 |
| Pol | We could imagine also a default devShell that would provide all the tools needed for a PHP core developer :) | 11:07:23 |
| Pol | We could imagine a Github action what would check if a commit is not breaking the builds ! :) | 11:14:36 |
| Pol | Plenty of new possibilities !!! | 11:14:44 |
| Pol | PR is green ^^ | 13:10:22 |
