| 2 Sep 2023 |
Lars Strojny | Terrific, thank you very much | 07:33:45 |
Pol | * php = pkgs.api.buildPhpFromComposer {
src = inputs.self;
php = pkgs.php83; # Change to php81, php82, php83 etc.
withExtensions = [
(pkgs.php83.extensions.xdebug.overrideAttrs (oldAttrs: {
src = pkgs.fetchFromGitHub {
owner = "xdebug";
repo = "xdebug";
rev = "7d10e631c17694913eadafb9a07da22fb3736b2c";
hash = "sha256-El6kdI1rOTWbwmX8bL1yB9KPwpew8GNK+lOb6h3KiOI=";
};
}))];
};
| 07:33:59 |
Pol | * php = pkgs.api.buildPhpFromComposer {
src = inputs.self;
php = pkgs.php83; # Change to php81, php82, php83 etc.
withExtensions = [
(pkgs.php83.extensions.xdebug.overrideAttrs (oldAttrs: {
src = pkgs.fetchFromGitHub {
owner = "xdebug";
repo = "xdebug";
rev = "7d10e631c17694913eadafb9a07da22fb3736b2c";
hash = "sha256-El6kdI1rOTWbwmX8bL1yB9KPwpew8GNK+lOb6h3KiOI=";
};
}))
];
};
| 07:34:14 |
Pol | Let me know how it goes | 07:34:49 |
Lars Strojny | Seems to be still picking up the stock version. This is the flake: https://github.com/lstrojny/uffff/blob/php-8.3/flake.nix
trace: warning: The pcre extension does not exist or is enabled by default in PHP 8.3.0RC1, ignoring.
trace: warning: The pcre extension does not exist or is enabled by default in PHP 8.3.0RC1, ignoring.
error: builder for '/nix/store/jvaykbfdbmsn32ws08wrym63b490alk6-php-xdebug-3.2.2.drv' failed with exit code 1;
last 10 log lines:
> checking for PHP includes... -I/nix/store/h74ww6409cjw2rrvzy9mc5w6cy54imb0-php-8.3.0RC1-dev/include/php -I/nix/store/h74ww6409cjw2rrvzy9mc5w6cy54imb0-php-8.3.0RC1-dev/include/php/main -I/nix/store/h74ww6409cjw2rrvzy9mc5w6cy54imb0-php-8.3.0RC1-dev/include/php/TSRM -I/nix/store/h74ww6409cjw2rrvzy9mc5w6cy54imb0-php-8.3.0RC1-dev/include/php/Zend -I/nix/store/h74ww6409cjw2rrvzy9mc5w6cy54imb0-php-8.3.0RC1-dev/include/php/ext -I/nix/store/h74ww6409cjw2rrvzy9mc5w6cy54imb0-php-8.3.0RC1-dev/include/php/ext/date/lib
> checking for PHP extension directory... /nix/store/ry064mmz1j95pvnyy8g2f2x8n76yvmsj-php-8.3.0RC1/lib/php/extensions
> checking for PHP installed headers prefix... /nix/store/h74ww6409cjw2rrvzy9mc5w6cy54imb0-php-8.3.0RC1-dev/include/php
> checking if debug is enabled... no
> checking if zts is enabled... no
> checking for gawk... gawk
> checking whether to enable Xdebug support... yes, shared
> checking whether to enable Xdebug developer build flags... no
> checking whether to compress profiler files (requires zlib)... yes
> checking Check for supported PHP versions... configure: error: not supported. Need a PHP version >= 8.0.0 and < 8.3.0 (found 8.3.0RC1)
For full logs, run 'nix log /nix/store/jvaykbfdbmsn32ws08wrym63b490alk6-php-xdebug-3.2.2.drv'.
error: 1 dependencies of derivation '/nix/store/q23pzqnz65dhx33kp8sp8df2n6c5srj5-php-extra-init-8.3.0RC1.ini.drv' failed to build
error: 1 dependencies of derivation '/nix/store/vhx6kp081lwdckaaycs8gcrgfm05gd3r-php-with-extensions-8.3.0RC1.drv' failed to build
error: 1 dependencies of derivation '/nix/store/qy81pchx64hx5bwb84fgk6rmk320gwh7-nix-shell-env.drv' failed to build```
| 08:49:58 |
Lars Strojny | Slight correction. The override works but it looks like the set of extensions to be installed has xdebug twice. The old version automatically detected from composer.json and the new version | 13:01:01 |
Pol | Oh | 18:03:25 |
Pol | This is something I should fix. | 18:03:30 |
Pol | I'm going to work on this now. | 18:03:35 |
Pol | Fixed (https://github.com/loophp/nix-php-composer-builder/commit/a33e8556e3da8c66b49f61706585c9e7d9b96691) | 18:41:18 |
| 3 Sep 2023 |
Jan Tojnar | In reply to @drupol:matrix.org Should we add a package depending on PHP on the top level of nixpkgs or nested under php.packages ? See my comment: https://github.com/NixOS/nixpkgs/pull/252778 we typically want to avoid nesting unless it is needed (e.g. when the program behaves differently with different PHP versions) | 17:51:45 |
Pol | But we can pass a different version of PHP if needed as a parameter... No ? | 18:19:53 |
Jan Tojnar | Pol: sure, that is an option but a less convenient one. When choosing one needs to consider the expected usage patterns | 19:00:37 |
| 4 Sep 2023 |
Lars Strojny | This works now, thank you! | 06:39:10 |
Pol | Excellent news. | 08:32:15 |
Pol | Lars Strojny: Are you still working in PHP core lately? | 08:38:12 |
Lars Strojny | No, not lately | 08:47:05 |
Pol | Ok thanks. | 09:04:13 |
Pol | I ask that because Jan Tojnar and I tried a couple of months ago to build PHP snapshots from the Github sources. We couldn't get something working... hence, my question. | 09:05:35 |
Jan Tojnar | I still do not think it should be that difficult for a seasoned Nixpkgs packager (or autotools guru) to resolve but those are in short supply | 20:21:23 |
Pol | True. | 20:22:01 |
Pol | Still haven't found enough people to review my PR for the PHP Builder :D | 20:22:21 |
| 5 Sep 2023 |
| Andreas Schrägle left the room. | 15:00:47 |
Pol | Having fun with this new builder: https://main.elk.zone/mathstodon.xyz/@Pol/111014330585183529 | 20:04:38 |
| 7 Sep 2023 |
Lars Strojny | Pol: what kind of problems did you run into? | 09:10:42 |
Pol | I don't remember, maybe Jan Tojnar could tell you more. We had a branch where we tried to make it work here: https://github.com/fossar/nix-phps/pull/104 | 09:12:43 |
Pol | I've rebased that branch, going to push a minor update in the next hour. | 11:30:47 |
Pol | I have the feeling that it goes further... | 11:30:59 |
Pol | * I have the feeling that it goes further than the last time we tried... | 11:31:10 |
Pol |  Download image.png | 11:37:02 |