| 31 Aug 2023 |
 Pol | It's in here: https://github.com/loophp/nix-php-composer-builder/blob/main/src/build-support/build-php-from-composer.nix#L61 | 06:05:49 |
| Pol | I updated the message... I hope it's better :) | 07:59:46 |
 Lars Strojny | Q regarding php-composer-builder: how to override a package. E.g. to use PHP 8.3 with xdebug, the latest git revision needs to be build. Any pointers on how to override packages? | 10:05:05 |
| Pol | There's currently no xdebug for PHP 8.3 AFAIK | 10:42:10 |
| Pol | Can you share some nix code so I can give some directions? | 10:42:24 |
| Pol | (my availability on internet is reduced lately since my flight home has been cancelled, I had to stay in holidays one more week to get a flight back) | 10:43:04 |
| 2 Sep 2023 |
| Pol | Should we add a package depending on PHP on the top level of nixpkgs or nested under php.packages ? See my comment: https://github.com/NixOS/nixpkgs/pull/252778 | 07:12:30 |
| Pol | Lars Strojny: Here's a solution: | 07:31:27 |
| Pol | php = pkgs.api.buildPhpFromComposer {
src = inputs.self;
php = pkgs.php83; # Change to php81, php82, php83 etc.
withExtensions = [
(pkgs.php83.extensions.xdebug.overrideAttrs (oldAttrs: {
src = pkgs.fetchFromGitHub {
owner = "xdebug";
repo = "xdebug";
rev = "7d10e631c17694913eadafb9a07da22fb3736b2c";
hash = "sha256-El6kdI1rOTWbwmX8bL1yB9KPwpew8GNK+lOb6h3KiOI=";
};
}))
];
};
| 07:31:31 |
| Lars Strojny | Terrific, thank you very much | 07:33:45 |
| Pol | * php = pkgs.api.buildPhpFromComposer {
src = inputs.self;
php = pkgs.php83; # Change to php81, php82, php83 etc.
withExtensions = [
(pkgs.php83.extensions.xdebug.overrideAttrs (oldAttrs: {
src = pkgs.fetchFromGitHub {
owner = "xdebug";
repo = "xdebug";
rev = "7d10e631c17694913eadafb9a07da22fb3736b2c";
hash = "sha256-El6kdI1rOTWbwmX8bL1yB9KPwpew8GNK+lOb6h3KiOI=";
};
}))];
};
| 07:33:59 |
| Pol | * php = pkgs.api.buildPhpFromComposer {
src = inputs.self;
php = pkgs.php83; # Change to php81, php82, php83 etc.
withExtensions = [
(pkgs.php83.extensions.xdebug.overrideAttrs (oldAttrs: {
src = pkgs.fetchFromGitHub {
owner = "xdebug";
repo = "xdebug";
rev = "7d10e631c17694913eadafb9a07da22fb3736b2c";
hash = "sha256-El6kdI1rOTWbwmX8bL1yB9KPwpew8GNK+lOb6h3KiOI=";
};
}))
];
};
| 07:34:14 |
| Pol | Let me know how it goes | 07:34:49 |
| Lars Strojny | Seems to be still picking up the stock version. This is the flake: https://github.com/lstrojny/uffff/blob/php-8.3/flake.nix
trace: warning: The pcre extension does not exist or is enabled by default in PHP 8.3.0RC1, ignoring.
trace: warning: The pcre extension does not exist or is enabled by default in PHP 8.3.0RC1, ignoring.
error: builder for '/nix/store/jvaykbfdbmsn32ws08wrym63b490alk6-php-xdebug-3.2.2.drv' failed with exit code 1;
last 10 log lines:
> checking for PHP includes... -I/nix/store/h74ww6409cjw2rrvzy9mc5w6cy54imb0-php-8.3.0RC1-dev/include/php -I/nix/store/h74ww6409cjw2rrvzy9mc5w6cy54imb0-php-8.3.0RC1-dev/include/php/main -I/nix/store/h74ww6409cjw2rrvzy9mc5w6cy54imb0-php-8.3.0RC1-dev/include/php/TSRM -I/nix/store/h74ww6409cjw2rrvzy9mc5w6cy54imb0-php-8.3.0RC1-dev/include/php/Zend -I/nix/store/h74ww6409cjw2rrvzy9mc5w6cy54imb0-php-8.3.0RC1-dev/include/php/ext -I/nix/store/h74ww6409cjw2rrvzy9mc5w6cy54imb0-php-8.3.0RC1-dev/include/php/ext/date/lib
> checking for PHP extension directory... /nix/store/ry064mmz1j95pvnyy8g2f2x8n76yvmsj-php-8.3.0RC1/lib/php/extensions
> checking for PHP installed headers prefix... /nix/store/h74ww6409cjw2rrvzy9mc5w6cy54imb0-php-8.3.0RC1-dev/include/php
> checking if debug is enabled... no
> checking if zts is enabled... no
> checking for gawk... gawk
> checking whether to enable Xdebug support... yes, shared
> checking whether to enable Xdebug developer build flags... no
> checking whether to compress profiler files (requires zlib)... yes
> checking Check for supported PHP versions... configure: error: not supported. Need a PHP version >= 8.0.0 and < 8.3.0 (found 8.3.0RC1)
For full logs, run 'nix log /nix/store/jvaykbfdbmsn32ws08wrym63b490alk6-php-xdebug-3.2.2.drv'.
error: 1 dependencies of derivation '/nix/store/q23pzqnz65dhx33kp8sp8df2n6c5srj5-php-extra-init-8.3.0RC1.ini.drv' failed to build
error: 1 dependencies of derivation '/nix/store/vhx6kp081lwdckaaycs8gcrgfm05gd3r-php-with-extensions-8.3.0RC1.drv' failed to build
error: 1 dependencies of derivation '/nix/store/qy81pchx64hx5bwb84fgk6rmk320gwh7-nix-shell-env.drv' failed to build```
| 08:49:58 |
| Lars Strojny | Slight correction. The override works but it looks like the set of extensions to be installed has xdebug twice. The old version automatically detected from composer.json and the new version | 13:01:01 |
| Pol | Oh | 18:03:25 |
| Pol | This is something I should fix. | 18:03:30 |
| Pol | I'm going to work on this now. | 18:03:35 |
| Pol | Fixed (https://github.com/loophp/nix-php-composer-builder/commit/a33e8556e3da8c66b49f61706585c9e7d9b96691) | 18:41:18 |
| 3 Sep 2023 |
 Jan Tojnar | In reply to @drupol:matrix.org
Should we add a package depending on PHP on the top level of nixpkgs or nested under php.packages ? See my comment: https://github.com/NixOS/nixpkgs/pull/252778 we typically want to avoid nesting unless it is needed (e.g. when the program behaves differently with different PHP versions) | 17:51:45 |
| Pol | But we can pass a different version of PHP if needed as a parameter... No ? | 18:19:53 |
| Jan Tojnar | Pol: sure, that is an option but a less convenient one. When choosing one needs to consider the expected usage patterns | 19:00:37 |
| 4 Sep 2023 |
| Lars Strojny | This works now, thank you! | 06:39:10 |
| Pol | Excellent news. | 08:32:15 |
| Pol | Lars Strojny: Are you still working in PHP core lately? | 08:38:12 |
| Lars Strojny | No, not lately | 08:47:05 |
| Pol | Ok thanks. | 09:04:13 |
| Pol | I ask that because Jan Tojnar and I tried a couple of months ago to build PHP snapshots from the Github sources. We couldn't get something working... hence, my question. | 09:05:35 |
| Jan Tojnar | I still do not think it should be that difficult for a seasoned Nixpkgs packager (or autotools guru) to resolve but those are in short supply | 20:21:23 |
| Pol | True. | 20:22:01 |
