| 7 Jul 2023 |
 @etu:failar.nu | I'm actually confused of that it would work :D | 08:01:15 |
| @etu:failar.nu | However, I would propose a different approach | 08:01:27 |
 Pol | (couchbase PR here: https://github.com/NixOS/nixpkgs/pull/240673) | 08:01:28 |
| Pol | I can test with a temporary commit. | 08:01:42 |
| Pol | I don't have a darwin here. | 08:01:47 |
| Pol | Let me do that. | 08:01:50 |
| @etu:failar.nu | diff --git a/pkgs/top-level/php-packages.nix b/pkgs/top-level/php-packages.nix
index 2be6447f83b..83dd081003d 100644
--- a/pkgs/top-level/php-packages.nix
+++ b/pkgs/top-level/php-packages.nix
@@ -226,8 +226,6 @@ lib.makeScope pkgs.newScope (self: with self; {
imagick = callPackage ../development/php-packages/imagick { };
- inotify = callPackage ../development/php-packages/inotify { };
-
mailparse = callPackage ../development/php-packages/mailparse { };
maxminddb = callPackage ../development/php-packages/maxminddb { };
@@ -291,7 +289,9 @@ lib.makeScope pkgs.newScope (self: with self; {
xdebug = callPackage ../development/php-packages/xdebug { };
yaml = callPackage ../development/php-packages/yaml { };
- } // (
+ } // (lib.optionalAttrs (!stdenv.isDarwin) {
+ inotify = callPackage ../development/php-packages/inotify { };
+ }) // (
let
# This list contains build instructions for different modules that one may
# want to build.
| 08:04:22 |
| Pol | that's an alternative indeed | 08:08:10 |
| Pol | 
Download image.png | 08:09:03 |
| Pol | I would use the enable attribute | 08:10:07 |
| Pol | I guess that's why it has been created. | 08:11:19 |
| Pol | I should have used that for the blackfire extension as well. | 08:11:32 |
| @etu:failar.nu | But that's only for "built in" extensions right? | 08:12:00 |
| Pol | No | 08:12:07 |
| Pol | It's for all extensions | 08:12:17 |
| @etu:failar.nu | You sure? Because we have that list named extensionData which are for built in extensions only where it passes each of the entries through mkExtension and also filters on enable | 08:14:36 |
| Pol | Wait. | 08:14:35 |
| Pol | You're maybe right. | 08:14:39 |
| Pol | Yes, let me double check. | 08:14:44 |
| @etu:failar.nu | While the extensions list above is already assigned to the extensions attribute | 08:15:02 |
| @etu:failar.nu | and doesn't get filtered | 08:15:10 |
| Pol | Yes you're right, I was wrong | 08:15:19 |
| Pol | I'll update. | 08:15:33 |
| Pol | Job done. I added some comments. | 08:23:57 |
| @etu:failar.nu | I think you dropped a ; when moving blackfire up | 08:41:35 |
| @etu:failar.nu | So eval is broken | 08:41:39 |
| Pol | Fixed | 09:19:57 |
| Pol | Saw it just now | 09:20:01 |
| Pol | I'm looking for some help to get the couchbase extension working with recent version of PHP. I opened as PR here : https://github.com/NixOS/nixpkgs/pull/240673 but I can't get it compile at all. If you have some time, please have a look... | 15:37:21 |
 Jan Tojnar | In reply to @drupol:matrix.org
I should have used that for the blackfire extension as well. I would argue that removing packages from the set based on specific platform/version violates the principle of least surprise – people will find the package somewhere (e.g. in package search) and then they will have to wonder why it does not exist | 19:37:52 |
