| 4 Jul 2023 |
 Gaël Reyrol | symfony-cli misses a mainProgram yeah | 09:16:25 |
 @etu:failar.nu | I'm not sure why we rename the executable in postInstall though | 09:17:01 |
| Gaël Reyrol | It seems on the documentation it has to be named symfony | 09:18:00 |
| Gaël Reyrol | https://symfony.com/download#step-2-create-new-symfony-applications | 09:18:18 |
| Gaël Reyrol | I opened a PR to solve this: https://github.com/NixOS/nixpkgs/pull/241449 | 09:23:39 |
 Pol | Merci <3 | 09:38:59 |
| 7 Jul 2023 |
| Pol | Elis 🌱: The PR is to avoid such things: https://github.com/loophp/nix-shell/actions/runs/5479572069/jobs/9981620028 | 07:57:51 |
| Pol | This CI job tries to build a PHP version with all extensions enabled. | 07:58:07 |
| Pol | I've already fixed a couple of stuff (see the merged pr in https://github.com/fossar/nix-phps/pulls?q=is%3Apr+is%3Aclosed). | 07:58:35 |
| @etu:failar.nu | I see | 07:59:21 |
| Pol | Actually, building php with all extensions enabled is a good thing, it helped me spotting the issues on Linux and Darwin. | 07:59:52 |
| Pol | The only extension that I'm unable to fix is couchbase. I guess I will come back to it later... but right now it's the only extension where I'm totally blocked. | 08:00:27 |
| @etu:failar.nu | Does it work to set it like that? I'm not a big fan of having it separate from the inclusion of the package like that | 08:00:55 |
| @etu:failar.nu | I'm actually confused of that it would work :D | 08:01:15 |
| @etu:failar.nu | However, I would propose a different approach | 08:01:27 |
| Pol | (couchbase PR here: https://github.com/NixOS/nixpkgs/pull/240673) | 08:01:28 |
| Pol | I can test with a temporary commit. | 08:01:42 |
| Pol | I don't have a darwin here. | 08:01:47 |
| Pol | Let me do that. | 08:01:50 |
| @etu:failar.nu | diff --git a/pkgs/top-level/php-packages.nix b/pkgs/top-level/php-packages.nix
index 2be6447f83b..83dd081003d 100644
--- a/pkgs/top-level/php-packages.nix
+++ b/pkgs/top-level/php-packages.nix
@@ -226,8 +226,6 @@ lib.makeScope pkgs.newScope (self: with self; {
imagick = callPackage ../development/php-packages/imagick { };
- inotify = callPackage ../development/php-packages/inotify { };
-
mailparse = callPackage ../development/php-packages/mailparse { };
maxminddb = callPackage ../development/php-packages/maxminddb { };
@@ -291,7 +289,9 @@ lib.makeScope pkgs.newScope (self: with self; {
xdebug = callPackage ../development/php-packages/xdebug { };
yaml = callPackage ../development/php-packages/yaml { };
- } // (
+ } // (lib.optionalAttrs (!stdenv.isDarwin) {
+ inotify = callPackage ../development/php-packages/inotify { };
+ }) // (
let
# This list contains build instructions for different modules that one may
# want to build.
| 08:04:22 |
| Pol | that's an alternative indeed | 08:08:10 |
| Pol | 
Download image.png | 08:09:03 |
| Pol | I would use the enable attribute | 08:10:07 |
| Pol | I guess that's why it has been created. | 08:11:19 |
| Pol | I should have used that for the blackfire extension as well. | 08:11:32 |
| @etu:failar.nu | But that's only for "built in" extensions right? | 08:12:00 |
| Pol | No | 08:12:07 |
| Pol | It's for all extensions | 08:12:17 |
| @etu:failar.nu | You sure? Because we have that list named extensionData which are for built in extensions only where it passes each of the entries through mkExtension and also filters on enable | 08:14:36 |
| Pol | Wait. | 08:14:35 |
