| 22 Jun 2023 |
 Pol | version = "8.3.0";
hash = "";
base = (callPackage ./generic.nix (_args // {
inherit version hash;
})).overrideAttrs (oldAttrs: {
src = (fetchurl {
url = "https://downloads.php.net/~eric/php-8.3.0alpha2.tar.xz";
hash = "sha256-YLCxgiDcsBisOmAodf0h8HyaCIh+4i1Q7QZw/h4KR5I=";
});
patches = [
./fileinfo.patch
];
});
| 07:16:32 |
| Pol | tgerbet: I need to leave, I'll be back in the afternoon | 07:31:34 |
| Pol | I just posted this comment: https://github.com/php/php-src/issues/11408#issuecomment-1602150492 | 07:31:48 |
| Pol | We'll see... | 07:31:52 |
| Pol | Ok I got it working | 09:31:01 |
| Pol | Going to post a PR in a few minutes. | 09:31:07 |
| Pol | Ready for review: https://github.com/NixOS/nixpkgs/pull/239151 | 10:15:35 |
 tgerbet | I see in your change that I forgot to cleanup some lib.versionAtLeast php.version "8.1" conditions with the PHP 8.0 removal 😓 | 14:44:34 |
| Pol | Ca arrive même aux meilleurs ;)😁 | 15:42:06 |
| Pol | And also, there's some leftovers of php 8.0 in php-probe.nix (blackfire extension). | 17:47:21 |
| Pol | There's an issue with the php-probe extension... | 18:39:18 |
| Pol | https://gist.github.com/GrahamcOfBorg/eb307c2a2e15412c65011c546ceb982d | 18:39:21 |
| Pol | What's the flag to add in the metadata to disable it for php 8.3 ? I used broken but it's not the good one I think. | 18:40:15 |
| Pol | That issue is preventing me from merging PHP 8.3 right now | 18:44:36 |
| tgerbet | Maybe move the blackfire attribute into something optional? Something like
// lib.optionalAttrs (!(lib.versionAtLeast php.version "8.3")) {
blackfire = ...
}
| 19:07:42 |
| Pol | Where ? I haven't seen that | 19:16:18 |
| 23 Jun 2023 |
| Pol | PHP 8.3 PR is ready for your review/merge at: https://github.com/NixOS/nixpkgs/pull/239151 | 06:57:55 |
| Pol | I'm not satisfied with how the blackfire extension is managed, but I guess this is something I will likely refine very soon | 06:58:51 |
| Pol | Anything left to do in here before I leave ? ^^ | 16:32:11 |
| tgerbet | Too tired after a day of meetings but I will take a look tomorrow 🙂 | 16:38:56 |
| tgerbet | You might want to fetchpatch the patch fixing the build of fileinfo, it just got merged upstream | 16:39:44 |
| Pol | Oh good idea. Doing it right now. | 16:44:04 |
| Pol | Job done. | 16:47:59 |
| Pol | tgerbet: Tests are failing with PHP 8.3: https://logs.ofborg.org/?key=nixos/nixpkgs.239151&attempt_id=b3b3603d-9438-44a1-9fd5-482484952538 | 21:44:49 |
| Pol | I can reproduce the issue locally, but I wasn't able to fix it. | 21:45:08 |
| 24 Jun 2023 |
|  etu changed their profile picture. | 13:19:44 |
| 25 Jun 2023 |
| tgerbet | Looking at the stack traces the issue is caused when PHP do the clean up at the end of a request (it's the php_request_shutdown you see the stack trace) and more specifically when it deals with the sessions (php_rshutdown_session_globals).
nixosTests.php83.httpd and nixosTests.php83.pcre succeeds if you remove session from the list of enabled extensions | 11:09:18 |
| tgerbet | I do not think this is on us, I'm trying to bisect | 11:41:15 |
| tgerbet | Created https://github.com/php/php-src/issues/11529 | 13:18:59 |
| Pol | thanks for creating it and debugging it | 17:53:43 |
