| 21 Jun 2023 |
 Pol | Job done: https://github.com/NixOS/nixpkgs/pull/225401/commits/4bde179df98d7d8d21cb53598e33f83c45e9f787 | 21:23:00 |
 tgerbet | FYI on another topic, I'm currently bisecting the build issue of the PHP 8.3 fileinfo extension.
Building php83Extensions.fileinfo works directly from the sources when pearSupport is set to false | 21:28:01 |
| Pol | Oh I wish I could do that with you | 21:30:09 |
| Pol | I'm curious to see how you handle that. | 21:30:24 |
| tgerbet | https://gist.github.com/LeSuisse/5d9897f34d9c429854c8d8bfbf3835ef
/home/thomas/Workspace/PHP/php-src is my local clone of php-src that I'm bisecting | 21:35:59 |
| Pol | But this is not supposed to work | 21:38:19 |
| tgerbet | Yup it crashes when withPear is true | 21:38:50 |
| Pol | We already tried with Jan Tojnar in: https://github.com/fossar/nix-phps/pull/104 | 21:38:58 |
| Pol | So it crashes because of Pear ? | 21:39:39 |
| Pol | How come this thing is still alive ?! | 21:39:50 |
| Pol | (I'll review your PR tomorrow) | 21:40:49 |
| tgerbet | Well it's not happy about pear but maybe there are other issues when all the extensions are built, I did not test (yet) | 21:43:20 |
| Pol | mmh oki | 21:44:57 |
| Pol | I'll contine tomorrow | 21:46:46 |
| Pol | Btw, I just published a new PR for Guacamole: https://github.com/NixOS/nixpkgs/pull/237824 | 21:47:02 |
| Pol | Feel free to test/review ! | 21:47:08 |
| 22 Jun 2023 |
| Pol | alpha2 has been tagged: https://github.com/php/php-src/releases/tag/php-8.3.0alpha2 | 06:42:03 |
| Pol | I guess a new release is about to come. Hopefully the fileinfo issue is fixed. | 06:42:18 |
| tgerbet | It does not, I tried yesterday when I saw the tag | 06:59:58 |
| Pol | here we go: | 07:01:29 |
| Pol | version = "8.3.0";
hash = "";
base = (callPackage ./generic.nix (_args // {
inherit version hash;
})).overrideAttrs (oldAttrs: {
src = (fetchurl {
url = "https://downloads.php.net/~eric/php-8.3.0alpha2.tar.xz";
hash = "";
});
});
| 07:01:32 |
| Pol | Got a new comment: https://github.com/php/php-src/issues/11408#issuecomment-1601745012 | 07:02:52 |
| Pol | I'm compiling alpha2 | 07:07:12 |
| Pol | I'll see if fileinfo is building | 07:07:38 |
| Pol | But is still there in alpha2 | 07:08:29 |
| Pol | Trying the proposed patch. | 07:08:34 |
| Pol | Nope, same issue | 07:16:12 |
| Pol | version = "8.3.0";
hash = "";
base = (callPackage ./generic.nix (_args // {
inherit version hash;
})).overrideAttrs (oldAttrs: {
src = (fetchurl {
url = "https://downloads.php.net/~eric/php-8.3.0alpha2.tar.xz";
hash = "sha256-YLCxgiDcsBisOmAodf0h8HyaCIh+4i1Q7QZw/h4KR5I=";
});
patches = [
./fileinfo.patch
];
});
| 07:16:32 |
| Pol | tgerbet: I need to leave, I'll be back in the afternoon | 07:31:34 |
| Pol | I just posted this comment: https://github.com/php/php-src/issues/11408#issuecomment-1602150492 | 07:31:48 |
