| 12 Jun 2023 |
 tgerbet | In reply to @drupol:matrix.org
Is there someone who can review this commit and let me know if it's ok? Basically, this is a composer plugin: https://github.com/NixOS/nixpkgs/pull/225401/commits/cfce10ee2d809f9ab80469be79bff1253dcedd66 Maybe it would be best to retrieve the keys directly from the repository https://github.com/composer/composer.github.io
This way we are sure they do not suddenly change.
Do you need them at all? From my understanding those keys are only useful to verify the installer which we does not seem to be the case here
| 17:13:06 |
 Pol | Good idea with the Github repo. Going to do it. | 17:26:03 |
| Pol | Keys are required to avoid this: | 17:26:08 |
| Pol | 
Download image.png | 17:26:56 |
| Pol | On the top you have the version without it, on the bottom you have the version with it. | 17:27:04 |
| tgerbet | Oh okay, I did not know it was looking for that. Maybe it should be done directly in phpPackages.composer as it seems to also have the problem. It is probably not specific to your plugin | 17:32:35 |
| Pol | True, but I have no clue on how to integrate that. | 17:33:41 |
| Pol | Do you think adding a composerHome input to composer derivation is a good idea? | 17:34:01 |
| Pol | I just pushed the changes for the composer keys ! https://github.com/NixOS/nixpkgs/pull/225401/commits/9e1540b6f6f7055af9710aa1c8c83b9966953cce | 17:34:24 |
| tgerbet | In reply to @drupol:matrix.org
Do you think adding a composerHome input to composer derivation is a good idea? Probably not, it will break too many things (e.g. access to GH OAuth access token) | 17:38:55 |
| Pol | Mmhm I don't know | 17:40:15 |
| tgerbet | It looks like we only get those warnings/errors because we are using the phar and in this situation it expects to be able to upgrade itself https://github.com/composer/composer/blob/bbea3e5284fd859373c292c7f696f9647f9a59ef/src/Composer/Command/DiagnoseCommand.php#L152 | 17:41:33 |
| Pol | Actually, we can reproduce the same issue with the src version, let me do a poc | 17:42:25 |
| Pol | Oh no you're right | 17:43:34 |
| Pol | 
Download image.png | 17:43:37 |
| Pol | It only does that with the PHAR indeed. | 17:43:45 |
| Pol | So sad it doesnt use proper XDG standard. | 17:44:29 |
| Pol | So we could install those keys in a specific place and be done with it. | 17:44:44 |
| tgerbet | Yep. Since it is more of a Composer issue than something related to the plugin I would just let not bother with the keys in the plugin. It's not like a composer diagnose will be issue while building the PHP packages 😄 | 17:53:16 |
| Pol | I just wanted to be just pixel perfect... "just in case of... " | 17:58:04 |
| tgerbet | Unpacking the phar archive seems to work https://github.com/NixOS/nixpkgs/pull/237410 | 19:02:36 |
| Pol | Let me be completely honest with this | 19:21:23 |
| Pol | I don't think we should do that... | 19:21:36 |
| Pol | I believe we should let the phar untouched. | 19:21:56 |
| Pol | If something has to be fixed, it's in Composer, not in here | 19:22:12 |
| Pol | Let me comment in the PR so we can continue there. | 19:23:51 |
| Pol | tgerbet: Hope no hard feeling on this | 20:02:10 |
| Pol | * tgerbet: Hope no hard feelings on this | 20:02:14 |
| tgerbet | Oh no | 20:02:26 |
| tgerbet | Completely fine :) | 20:02:41 |
