| 9 Jun 2023 |
 Pol | Ok that's an option. | 10:50:10 |
| Pol | But I think here it's another issue. | 10:50:17 |
 @etu:failar.nu | * Pol: We've chosen to ignore tests for specific extensions on specific versions in the past, that's always an option but also a bit of a last resort 🙂 | 10:50:20 |
| Pol | See: https://github.com/php/php-src/issues/11408 | 10:50:38 |
| Pol | Especially the log | 10:50:42 |
| Pol |
php-fileinfo> Warning: PHP Startup: Invalid library (maybe not a PHP library) 'fileinfo.so' in Unknown on line 0
| 10:51:00 |
| Pol | And given the amount of failures, I doubt that the issues comes from a bad tests... I guess it comes from somewhere else. | 11:06:45 |
 Jan Tojnar | In reply to @drupol:matrix.org
See: https://github.com/php/php-src/issues/11408 that sounds pretty NixOS specific, probably too early to report it upstream. | 15:21:15 |
| Jan Tojnar | Try building with --keep-failed and look at what the file actually is | 15:21:33 |
| Pol | I'm back. | 19:34:53 |
| Pol | Jan Tojnar: I've checked the fileinfo.so file and added the info in the issue. | 19:35:40 |
| Pol | TBH, I don't know what I'm looking for yet. | 19:35:51 |
| Jan Tojnar | In reply to @drupol:matrix.org
TBH, I don't know what I'm looking for yet. looks okay to me, I guess time to bisect | 19:43:30 |
| Pol | bisect... ? PHP ? | 19:43:43 |
| Pol | Curious to see how you do that | 19:44:10 |
| Jan Tojnar | you can set src of the Nix package to the path to your local php-src checkout | 19:44:59 |
| Jan Tojnar | and then run git bisect run nix-build ~/Projects/nixpkgs -A php | 19:45:25 |
| Pol | Ok | 19:45:53 |
| Pol | Going to try | 19:45:55 |
| Jan Tojnar | might need to adjust the expression a bit to allow for differences from the tarball | 19:46:30 |
| Jan Tojnar | so best try building it on the known good/bad tags first | 19:47:15 |
| Pol | So, the first commit will be the one tagged with 8.2.7 I guess. | 19:47:50 |
| Pol | Oh boy the branch management in the php project, I don't get it. | 19:49:22 |
| Pol | Feel free to take care of it I don't know if I will be able to do it. | 20:30:00 |
| Jan Tojnar | I think I will leave it to PHP maintainers, still have bunch of GNOME libraries I need to update 😆 | 20:40:45 |
| 12 Jun 2023 |
| @etu:failar.nu | By the time we drop 8.0 we should probably move to 8.2 as default as well 🙂 | 09:02:51 |
| Pol | Is there someone who can review this commit and let me know if it's ok? Basically, this is a composer plugin: https://github.com/NixOS/nixpkgs/pull/225401/commits/8b034b8edc879c62eab285c46256c47bb05a72f7 | 16:38:10 |
| Pol | * Is there someone who can review this commit and let me know if it's ok? Basically, this is a composer plugin: https://github.com/NixOS/nixpkgs/pull/225401/commits/858868a383ea9c071e69f99e9e10c3793547d381 | 16:42:53 |
| Pol | * Is there someone who can review this commit and let me know if it's ok? Basically, this is a composer plugin: https://github.com/NixOS/nixpkgs/pull/225401/commits/cfce10ee2d809f9ab80469be79bff1253dcedd66 | 16:58:28 |
| Pol | (link updated) | 17:02:22 |
