Nix PHP | 77 Members | |
| A room for PHP developers running on Nix | 22 Servers |
| Sender | Message | Time |
|---|---|---|
| 20 May 2023 | ||
In reply to @jtojnar:matrix.orgyeah... maybe we will discover issue once I will update all the vendorHash in the PR. | 16:41:19 | |
I would put it into the configure part along with composer update --lock --no-install --no-ansi | 16:41:51 | |
I mean, should we add it in the script building the repo or in the script running composer install ? | 16:42:38 | |
I mean the division between setup-hook.sh and fetch-deps.nix I used for composition-c4 is still the ideal design IMO | 16:43:24 | |
| yeah I noticed, I like it very much | 16:43:39 | |
Would you be ok to contribute in drupol/composer-local-repo-plugin and to improve it if you feel like it needs to be improved ? | 16:44:20 | |
| I'm going to close the laptop, got friends over today, but I'm happy of this thing ! We can move forward a little bit :) | 16:45:18 | |
| See you later! | 16:45:26 | |
| not sure when I will be able to get around it, still have two other projects I wanted to do this week 😸 | 16:45:54 | |
| enjoy | 16:46:08 | |
| I mean, feel free to modify it at anytime :) | 16:54:10 | |
| I think it needs improvements | 16:54:24 | |
| For example, | 16:54:30 | |
We should make sure that keys are sorted alphabetically in the produced packages.json | 16:54:45 | |
| So we don't have surprise at some point. | 16:54:59 | |
Changing the structure of that single packages.json file and we are good to re-compute all the derivation hashes | 16:55:20 | |
| So we need to fix the structure of that file | 16:55:27 | |
| And avoid modifying it once it's done. | 16:55:34 | |
| Then we tag that plugin and we're good to go. | 16:55:43 | |
| We should also think about where to put that project | 16:56:47 | |
| 21 May 2023 | ||
| I've updated the composer plugin with new commands options:
| 10:11:52 | |
I made those options to reduce the amount of file manipulation in pkgs/build-support/php/hooks/composer-install-hook.sh | 10:12:30 | |
| The package installation procedure is now reduced to:
| 10:13:09 | |
| I also updated the plugin to output json in alphabetical order | 10:13:39 | |
| 22 May 2023 | ||
| Today I will most probably write a summary of all the things we tried to get this thing working. | 06:58:52 | |
| I've been testing that thing the whole weekend, and I improved it here and there as you can see in the PR. | 06:59:19 | |
| There is only ONE single issue with that method. | 06:59:31 | |
If by any change you have post-update-cmd in composer.json like in Drupal: https://github.com/drupal/drupal/blob/11.x/composer.json#L111This is going to fail. | 07:00:30 | |
Why? Because as far as I can see, the update command is expected to be run AFTER the install command and the autoloader needs to be loaded so the update command can run the command properly. | 07:01:14 | |
But in our case, we are running the update command BEFORE the install command: https://github.com/NixOS/nixpkgs/blob/58fed5f92032c4e51286d08a76d9d2bab5443ecb/pkgs/build-support/php/hooks/composer-install-hook.sh#L52 | 07:02:18 | |