| 20 May 2023 |
Jan Tojnar | well, I guess we could return includeDev flag but only use it to decide what to fetch but still include everything in the repository’s packages.json | 14:09:25 |
Jan Tojnar | then the paths for dev packages would not exist but it would not matter | 14:10:11 |
Jan Tojnar | * then the paths for dev packages would not exist but it would not matter as long as user always uses --no-dev | 14:10:22 |
Pol | I don't know if this would work. | 14:12:42 |
Pol | Imagine phpstan/phpstan is a hard dependency of a dependency. | 14:13:00 |
Pol | We would not download it then? | 14:13:12 |
Pol | (btw, I added you as maintainer of https://github.com/drupol/composer-local-repo-plugin/ and cherry picked one of your commit from composition/c4) | 14:14:03 |
Pol | I think that composer plugin should be hosted in nixpkgs, and not under my name. | 14:14:26 |
Pol | But ok, we can deal with that later. | 14:14:45 |
Pol | I think I made something okayish. | 14:55:29 |
Pol | I will push in a couple of seconds. Waiting for phpunit to be build. | 14:55:47 |
Jan Tojnar | In reply to @drupol:matrix.org Imagine phpstan/phpstan is a hard dependency of a dependency. I would expect it to be listed in packages then | 15:24:45 |
Jan Tojnar | In reply to @drupol:matrix.org Imagine phpstan/phpstan is a hard dependency of a dependency. * I would expect it to be listed in packages section of composer.lock then | 15:24:58 |
Pol | How about using jq to nuke require-dev from composer.json and packages-dev from composer.lock ? :D | 15:34:43 |
Pol | I just pushed the changes in the branch. | 15:34:50 |
Pol | The two working derivations are composer and phpunit. | 15:35:01 |
Pol | In reply to @drupol:matrix.org How about using jq to nuke require-dev from composer.json and packages-dev from composer.lock ? :D I just tested this, it works pretty well actually. | 16:09:41 |
Pol | Building composer takes 1 minute now instead of 10 before | 16:11:45 |
Pol | 43 seconds actually. | 16:13:08 |
Pol | OMG... It also fix psaln :D | 16:19:06 |
Pol | Going to commit all of this | 16:19:11 |
Pol | * OMG... It also fix psalm :D | 16:20:42 |
Pol | Jan Tojnar Gaël Reyrol ^^ breakthrough ^^ | 16:20:58 |
Pol | In reply to @drupol:matrix.org How about using jq to nuke require-dev from composer.json and packages-dev from composer.lock ? :D That seems to be actually a good idea ! | 16:21:23 |
Pol | I just pushed everything :D | 16:21:41 |
Pol | https://github.com/NixOS/nixpkgs/pull/232450/files#diff-8b7b6933957bf6ee2ddf23b376fe97a96708ced9cdaf1fcb26f452873a76723dR41 | 16:22:15 |
Pol | jq '."packages-dev" = []' composer.lock > newComposer.lock
mv newComposer.lock composer.lock
jq '."require-dev" = {}' composer.json > newComposer.json
mv newComposer.json composer.json
| 16:22:24 |
Pol | That stuff fixed everything | 16:22:29 |
Pol | I have the feeling that we finally see some light at the end of the tunnel. | 16:30:58 |
Pol | I'm testing it here, I can't make it fail anymore! | 16:31:14 |