| 12 May 2023 |
 Pol | * hexa: I don't understand the attribute propagatedBuildInputs. nix-init add some for abstract-singleton, should I add them ? | 16:25:48 |
 hexa | those are the runtime requirements for python packages | 16:27:04 |
| hexa | the things it imports | 16:27:09 |
| hexa | post what it created | 16:27:15 |
| hexa | and ideally the link to the setup.py/pyproject.toml | 16:27:23 |
| Pol | Shouldn't it be in buildInputs ? | 16:27:22 |
| Pol | python3.pkgs.buildPythonApplication rec {
pname = "abstract-singleton";
version = "1.0";
format = "pyproject";
src = fetchFromGitHub {
owner = "BillSchumacher";
repo = "Abstract-Singleton";
rev = version;
hash = "sha256-lHKU3tXTp/aDa9X8iXk49qyL5Zp+xFYQUX/xTAFS0nw=";
};
nativeBuildInputs = [
python3.pkgs.hatchling
];
propagatedBuildInputs = with python3.pkgs; [
black
build
flake8
isort
pylint
twine
wheel
];
pythonImportsCheck = [ "abstract_singleton" ];
meta = with lib; {
description = "";
homepage = "https://github.com/BillSchumacher/Abstract-Singleton";
license = licenses.mit;
maintainers = with maintainers; [ ];
};
}
https://github.com/BillSchumacher/Abstract-Singleton/blob/main/pyproject.toml
| 16:28:07 |
| Pol | This has been generated with nix-init | 16:28:30 |
| hexa | ugh, that looks like a lot of dev tools | 16:28:51 |
| hexa | also you should be using buildPythonPackage for libraries | 16:29:13 |
| hexa | the packages were mostly fine fwiw | 16:29:20 |
| hexa | wouldn't replace them with nix-init now | 16:29:25 |
| hexa | it's probably using https://github.com/BillSchumacher/Abstract-Singleton/blob/main/requirements.txt | 16:29:34 |
| hexa | which is not ideal 😄 | 16:29:38 |
| Pol | I'm not going to replace it with nix-init, just using nix-init for the meta infos. | 16:30:59 |
| Pol | But I see that the propagatedBuildInputs are added, so I wonder. | 16:31:11 |
| hexa | oh and commits should have an explicit python version, ideally the default, which is 3.10 😄 | 16:37:17 |
| hexa | python310Packages.package | 16:37:21 |
| hexa | this is the only way to automatically build them on ofborg | 16:37:33 |
| hexa | python3Packages for some reason doesn't do that | 16:37:38 |
| Pol | Oki will do. | 16:43:04 |
| hexa | apparently the php80 removal was brought up in https://github.com/NixOS/nixpkgs/issues/224505 | 17:25:00 |
| 13 May 2023 |
| Pol | PHP Bump PR is ready: https://github.com/NixOS/nixpkgs/pull/230941 | 07:11:07 |
| Pol | We should also move on with: https://github.com/NixOS/nixpkgs/pull/227753 | 08:53:10 |
| 15 May 2023 |
| hexa | Elis 🌱: openssl 1.1 is going to be marked eol for 23.05; what about the php 8.0 removal? https://github.com/NixOS/nixpkgs/issues/224457#issuecomment-1495393406 | 19:10:08 |
| Pol | Let's get rid of PHP80 | 19:18:22 |
 Shyim | looking for reviewers :) https://github.com/NixOS/nixpkgs/pull/232079 | 19:50:33 |
| Pol | In reply to @shyim:matrix.org
looking for reviewers :) https://github.com/NixOS/nixpkgs/pull/232079 Added some nits ! :) | 20:08:15 |
| hexa | In reply to @drupol:matrix.org
Let's get rid of PHP80 needs someone to invest the time | 20:31:18 |
| hexa | ideally a maintainer | 20:31:25 |
