| 25 Apr 2023 |
 tgerbet | Great! Because to be honest I was not really a big fan of mine | 18:08:45 |
 Pol | 
Download image.png | 18:09:15 |
| Pol | WDYT of that? | 18:09:18 |
| Pol | Basically, I merge 2 composer.json files together to override. | 18:09:34 |
| Pol | I think it's cleaner to do that. | 18:09:45 |
| tgerbet | Yep indeed, it's more readable 👍️ | 18:10:45 |
| Pol | We could even let users customize the overrides. | 18:10:58 |
| Pol | But this could be done in a next phase. | 18:11:05 |
| Pol | Regarding this: | 18:12:53 |
| Pol | 
Download image.png | 18:12:55 |
| Pol | I don't know that thing yet. | 18:13:01 |
| tgerbet | Yeah this is the hard part :/
Both options have trade-offs, I'm not sure if one is really better than the other or if there is another way to explore | 18:15:39 |
| Pol | yeah it's scary. | 18:18:52 |
| Pol | I don't know what to think yet there. | 18:19:09 |
| Pol | Would be nice to have some additional inputs from others. | 18:19:24 |
| Pol | Added in the doc:
As the autoloader optimization can be activated directly within the
`composer.json` file, we do not enable any autoloader optimization flags.
| 18:23:02 |
 Jan Tojnar | tgerbet, Pol both vendor directory and cache sound too much to me like it could change whenever composer wants | 19:34:34 |
| Jan Tojnar | I would just create a new composer repository like composition-c4 does | 19:35:06 |
| Jan Tojnar | and make FOD of that | 19:35:11 |
| Jan Tojnar | of course, you would still need to clean out the .git directories | 19:35:45 |
| Jan Tojnar | but sounds like the method with least amount of jank | 19:36:14 |
| Pol | I updated the docs with how to override the composer.json file. | 20:05:56 |
| 26 Apr 2023 |
| Pol | I'd be happy to merge features from your project in here, but I don't know where to begin. I haven't fully grasped yet what makes it more efficient. | 05:05:49 |
| Jan Tojnar | it is not really more efficient but it is a different approach that will not change when composer changes | 05:42:46 |
| Jan Tojnar | since it is basically creating a packagist mirror | 05:43:10 |
| Pol | But it only works for git based deps, right ? | 05:43:42 |
| Jan Tojnar | that is the limitation of composition-c4 because it uses builtins.fetchGit but it will not be a problem for you, when you will use a different fetcher (e.g. git clone inside FOD) | 05:44:46 |
| Jan Tojnar | I meant composition-c4 only as approach, the implementation will need to be completely different | 05:45:33 |
| Pol | Let's push the idea further and try to implement it correctly then | 05:45:52 |
| Pol | So at some point composition-c4 will be obsolete 😅 | 05:46:21 |
