| 21 Apr 2023 |
Pol |  Download image.png | 13:41:30 |
Pol | First time I see that ! | 13:41:34 |
Pol | Do you think there is something else to add in the documentation? https://github.com/NixOS/nixpkgs/pull/225401/commits/28476ebe01e058bd5fceeaf4fd88a077dbed9e10 | 18:19:36 |
| 22 Apr 2023 |
Pol | I modified and updated the documentation. | 09:28:05 |
Pol | I also set the PR as ready to review: https://github.com/NixOS/nixpkgs/pull/225401 | 09:28:11 |
| 23 Apr 2023 |
Pol | I don't understand that. | 09:15:09 |
Pol | https://github.com/NixOS/nixpkgs/pull/226845 | 09:15:11 |
Pol | My mistake. | 09:20:49 |
Pol |  Download image.png | 09:30:03 |
Pol | Jan Tojnar: Do you think it would be a good idea to add this in php builder ? | 09:30:11 |
Jan Tojnar | Pol: Sandro suggested using the PHP's platforms | 09:51:22 |
Jan Tojnar | * Pol: Sandro already suggested using the PHP's platforms | 09:51:43 |
Pol | So, `php.meta.platforms` ? | 09:53:46 |
Shyim | Does someone know why grpc for PHP is never cached for darwin? I have no idea what I should look for in Hydra | 18:52:40 |
| 24 Apr 2023 |
Pol | Nope sorry :S | 08:13:32 |
Pol | Jan Tojnar: renamming buildComposerProject into mkComposerApp would make better sense? | 08:14:06 |
Jan Tojnar | Pol: I think there can be more than just apps | 09:21:57 |
Pol | Do you suggest a better naming? Or it is ok as it is ? | 09:34:39 |
Jan Tojnar | I think buildComposerProject is good enough | 09:38:09 |
Pol | Okidocky | 09:40:17 |
Pol | Since it was a mkDerivation, I though naming it with mkSomething was a better option. | 09:40:38 |
Pol | Jan Tojnar: I'm banging my head with psalm. Trying to understand why it's failing to be packaged with the new builder. | 18:33:04 |
Pol | If you could give it a try... | 18:33:10 |
Pol | Here's the derivation: | 18:33:15 |
Pol | { lib, fetchFromGitHub, php }:
php.buildComposerProject (finalAttrs: {
pname = "psalm";
version = "5.9.0";
src = fetchFromGitHub {
owner = "vimeo";
repo = "psalm";
rev = finalAttrs.version;
hash = "sha256-yoDJPBoRaKGd78sJoQj26T3+x2QxbHAbH/lnbTJcnIM=";
};
# TODO: Open a PR against https://github.com/sebastianbergmann/phpunit
# Missing `composer.lock` from the repository.
composerLock = ./composer.lock;
vendorHash = "";
})
| 18:33:34 |
Pol | It's failing during the composerSetupBuildHook | 18:33:51 |
Pol |  Download image.png | 18:34:19 |
Pol | I just cannot find the reason why it's failing. | 18:34:30 |
Pol | When I clone the project locally, this is working fine. | 18:34:38 |
Jan Tojnar | Pol: 1.0.0+no-version-set looks suspicious | 19:02:55 |