| 21 Apr 2023 |
Pol | (in big PRs) | 10:34:13 |
Jan Tojnar | ugh, I dislike that composer calls executable programs/scripts binaries | 10:38:23 |
Pol | like? git? unzip? xz ? | 10:38:59 |
Jan Tojnar | I mean as a naming scheme | 10:47:42 |
Pol | Oooh right, I agree. | 10:49:55 |
Pol | I added a sentence about PHP binaries. | 10:58:11 |
Pol |  Download image.png | 10:58:26 |
Pol | Jan Tojnar: Should we rename php.buildComposerDeps to php.buildComposerVendorCache ? | 11:00:01 |
Pol | * Jan Tojnar: Should we rename php.buildComposerDeps to php.mkComposerVendorCache ? | 11:00:14 |
Jan Tojnar | probably makes sense | 11:03:26 |
Pol | Ok will do. | 11:03:41 |
Pol | I can tell that documentation and naming is crucial for newcomers. | 11:05:11 |
Jan Tojnar | maybe also runComposerScripts | 11:05:44 |
Pol | To replace what? | 11:05:56 |
Jan Tojnar | installComposerPluginsDependencies | 11:06:17 |
Pol | erm, there's no such thing | 11:06:36 |
Pol | oops. | 11:06:45 |
Jan Tojnar | similar for the plug-ins | 11:06:48 |
Jan Tojnar | since it controls whether they will be run | 11:07:08 |
Pol | so, s/installComposerPluginsDependencies/runComposerScripts ? | 11:07:38 |
Pol | nothing else? | 11:07:45 |
Pol | * so, s/installComposerScriptsDependencies/runComposerScripts ? | 11:09:22 |
Pol | then s/installComposerPluginsDependencies/runComposerPlugins ? | 11:09:38 |
Pol | something else while I'm into renaming ? | 11:09:55 |
Jan Tojnar | not at the moment | 11:12:58 |
Pol | voila, commit/pushed. | 11:13:44 |
Pol | I'm going for lunch, I'll be back in the afternoon. Cheers! | 11:13:57 |
Jan Tojnar | enjoy | 11:15:15 |
Pol | Jan Tojnar I made a small modification and added the attribute patches => patches = previousAttrs.patches or []; | 13:09:11 |
Pol | What is this in Github? | 13:41:28 |