| 21 Apr 2023 |
 Pol | So, you would merge the bash script in the nix function ?! | 08:30:38 |
 Jan Tojnar | yeah. I think the composerInstallHook is useful when building multi-language projects but almost everything can just use buildComposerDeps | 08:33:30 |
| Pol | Damn, it's been years that I'm using VSCode, I've never found a faster way to do commit fixup in the UI. I always need to do the rebase manually after. | 08:34:00 |
| Pol | In reply to @jtojnar:matrix.org
yeah. I think the composerInstallHook is useful when building multi-language projects but almost everything can just use buildComposerDeps Can we revisit this later if needed ? | 08:34:23 |
| Jan Tojnar | generally, it is easier to add API then remove it | 08:35:10 |
| Jan Tojnar | but I do not care much either way, the important thing is that the installHook and buildComposerDeps exists | 08:35:41 |
| Pol | In reply to @jtojnar:matrix.org
yeah. I think the composerInstallHook is useful when building multi-language projects but almost everything can just use buildComposerDeps But that hook is responsible for doing the installation and creating the vendor dir. While buildComposerDeps is only building the composer cache in .composer directory. | 08:36:12 |
| Jan Tojnar | right, I am talking about merging the composerSetupHook, composerInstallHook would remain | 08:36:59 |
| Pol | So, basically, instead of having 3 function in composerSetupHook, have only one function ? | 08:37:31 |
| Pol | * So, basically, instead of having 3 functions in composerSetupHook, have only one function ? | 08:37:38 |
| Pol | I think this is my biggest PR so far in the Nix project. | 08:45:07 |
| Pol | (and the documentation is not yet written) | 08:45:20 |
| Pol | I think I'm going to start the documentation today. Do you have a piece of advice on where I should start writing all those new things? | 08:50:06 |
| Pol | here? doc/languages-frameworks/php.section.md | 08:50:29 |
| Pol | * here? doc/languages-frameworks/php.section.md | 08:50:35 |
| Pol | Things are going well: | 09:19:53 |
| Pol | 
Download image.png | 09:19:58 |
| Pol withdrew  @shyim-5532ae2f15522ed4b3df33d3:gitter.im's invite. | 09:20:22 |
 @etu:failar.nu | In reply to @drupol:matrix.org
here? doc/languages-frameworks/php.section.md That's a good place yes :) | 09:38:27 |
| Pol | I started here: https://github.com/NixOS/nixpkgs/pull/225401/commits/b3e440525021f5cd8cce65d46ed5f2a40f412c46 | 09:53:56 |
| Pol | Let me know what you think about that already. | 09:55:29 |
| Pol | The more feedback I have, the better it is. | 09:55:36 |
| Pol | * I started here: https://github.com/NixOS/nixpkgs/pull/225401/commits/4876d0b2eb9b3417e4420fff3164abfd4d214632 | 09:55:54 |
| Pol | Jan Tojnar: For phpcbf, is it what you have in mind? | 10:12:19 |
| Pol | 
Download image.png | 10:12:21 |
| Jan Tojnar | Pol: exactly that | 10:14:12 |
| Pol | Ok | 10:14:43 |
| Pol | config and callPackages are not available in that file. | 10:14:51 |
| Pol | Working on it. | 10:14:53 |
| Pol | fixed. | 10:15:20 |
