| 11 Apr 2023 |
Jan Tojnar | so that the projects can continue doing that like grumphp did | 20:05:40 |
Pol | I will try. | 20:16:48 |
Pol | I almost got rid of most of .phar based derivation. | 20:17:19 |
Pol | * I almost got rid of most of .phar based derivations. | 20:18:06 |
Pol | remains psalm, drush and deployer. | 20:18:32 |
Pol | But I can't do it | 20:18:55 |
Pol | I gladly accept some help for the finalAttrs pattern :) | 20:32:32 |
| 12 Apr 2023 |
Pol | Lars Strojny: Nice ! https://symfony.com/blog/new-in-symfony-reproducible-builds I didn't know you worked on this ! | 05:14:43 |
Pol | Jan Tojnar: if you have a bit of time today to show me how to implement finalAttrs in buildPhpProject, I'll be grateful :) | 05:43:43 |
Jan Tojnar | Pol: maybe in the evening | 06:11:44 |
Jan Tojnar | note that LeSuisse points out that the autoloader code, while deterministic still is not stable across composer versions | 06:12:34 |
Pol | Anytime :) | 06:17:26 |
Pol | Yeah we will have to deal with those deterministic stuff at some point. | 06:17:44 |
Pol | a bit overwhelmed with all those comments, but i'll sort it out slowly :) | 07:37:12 |
Pol | tgerbet: Thanks for those valuable feedback | 07:37:20 |
Jan Tojnar | Pol: you can check https://github.com/NixOS/nixpkgs/pull/194475 for the finalAttrs support | 17:06:16 |
Pol | Checking now. | 23:25:50 |
Pol | Ok finalAttrs pattern is done! :) | 23:57:11 |
| 13 Apr 2023 |
Jan Tojnar | Pol: I would still drop the [[ -e "${composerLock}" ]] | 18:21:19 |
Pol | Righty | 18:21:26 |
Pol | I though it was a good idea to have it | 18:21:40 |
Jan Tojnar | otherwise it will silently fall back to the lock file from src | 18:21:45 |
Pol | Oki | 18:21:53 |
Jan Tojnar | when invalid value is passed | 18:21:54 |
Jan Tojnar | which will be a head scratcher | 18:22:12 |
Pol | Removed | 18:22:17 |
Jan Tojnar | removing it will make it fail loudly by cp failing | 18:22:32 |
Pol | I see. Fair enough :) | 18:23:08 |
Pol | Job done. | 18:23:10 |
Pol | I'm still wondering if what I'm doing there is a good idea or not. | 18:23:24 |