| 17 Feb 2023 |
 Pol | In reply to @tgerbet:matrix.org
Do you see failures for PHP 7.x ? Maybe you could be stricter and only apply it on >= 8.0 ? I mean, there is failure only for PHP 5.6, 7.0, 7.1. | 08:46:11 |
| Pol | In reply to @tgerbet:matrix.org
Do you see failures for PHP 7.x ? Maybe you could be stricter and only apply it on >= 8.0 ? * There are failure only for PHP 5.6, 7.0, 7.1. | 08:46:19 |
 tgerbet | Yes but the removal of the test files might not be needed in the range [7.2-7.4] if the tests are not flaky for some reasons | 08:47:37 |
| tgerbet | I have no clue if that's the case or not TBH | 08:48:59 |
| Pol | It's now green with that PR: https://github.com/loophp/nix-shell/pull/131 | 08:59:00 |
| 20 Feb 2023 |
| Pol | Someone submitted a PR to have PHPUnit in Nix at https://github.com/NixOS/nixpkgs/pull/217207 | 09:49:09 |
 @etu:failar.nu | I think that for phpunit it may matter which version of PHP you run it with | 09:55:38 |
| @etu:failar.nu | And then it should be below php-packages so you can select version | 09:55:53 |
| Pol | I don't think the same, maybe we should discuss that in the thread then? WDYT ? | 10:03:57 |
| Pol | I think we shouldn't take care of the PHP version here and always use the latest. | 10:04:15 |
| Pol | In reply to @etu:failar.nu
I think that for phpunit it may matter which version of PHP you run it with I could also ask Sebastian (phpunit's father) about that. We could also check how they do in other distro? | 10:06:46 |
| @etu:failar.nu | I think most people install it with composer | 10:19:07 |
| @etu:failar.nu | Then you have all the right things in place | 10:19:15 |
| @etu:failar.nu | I'm pretty confident that phpunit evaluates PHP with the version of PHP as you run PHP unit with. | 10:19:54 |
| @etu:failar.nu | So if you have phpunit built on php81 running against a codebase that requires php82 features... you'll have a bad time. | 10:20:26 |
| Pol | We really need to try then | 10:21:02 |
| Pol | Or ask Sebastian? | 10:21:15 |
| @etu:failar.nu | Sure, do it either way, then there were also a comment on the PR that is good | 10:21:42 |
| @etu:failar.nu | * Sure, do it either way, then there were also a comment on the PR that is good to consider | 10:21:59 |
| Pol | Which one? | 10:42:23 |
| 23 Feb 2023 |
|  void joined the room. | 13:23:59 |
| void | https://bugs.php.net/bug.php?id=81744 | 13:24:11 |
| void | hexa ^^^ | 13:24:24 |
 hexa | cc Pol etu tgerbet | 13:25:13 |
| void | * https://bugs.php.net/bug.php?id=81744 https://github.com/php/php-src/security/advisories/GHSA-7fj2-8x79-rjf4 | 13:26:52 |
| @etu:failar.nu | 
Download image.png | 13:27:29 |
| tgerbet | Will took a look | 13:27:40 |
| @etu:failar.nu | Seems like we should be covered: https://github.com/php/php-src/security/advisories/GHSA-7fj2-8x79-rjf4 | 13:27:45 |
| tgerbet | * https://github.com/NixOS/nixpkgs/pull/216348 | 13:27:50 |
| tgerbet | Yep it was part of the last round of upgrades | 13:28:06 |
