| 14 Aug 2024 |
 piotrkwiecinski | damn patches :D | 13:16:03 |
| piotrkwiecinski | I have a fix on local for gettext but ext-dom fails with beta1 build
> Running phase: patchPhase
> applying patch /nix/store/hqrpdj07y97vwiyy29jizcsmvx9hdnys-8d7365b6f009ba43e305d6459013ac4fbed7c606.diff?full_index=1
> patching file ext/dom/tests/modern/extensions/Element_substitutedNodeValue.phpt
> Reversed (or previously applied) patch detected! Assume -R? [n]
> Apply anyway? [n]
> Skipping patch.
> 2 out of 2 hunks ignored -- saving rejects to file ext/dom/tests/modern/extensions/Element_substitutedNodeValue.phpt.rej
| 13:17:05 |
| piotrkwiecinski | maybe its because try to apply a patch to for alpha1 | 13:18:59 |
 Pol | #facepalm | 13:21:24 |
| piotrkwiecinski | if I'm not mistaken 8.4 is scheduled for the next staging-next merge | 13:22:33 |
| piotrkwiecinski | so we'll have to wait a bit till I can update it to beta1 | 13:22:51 |
| piotrkwiecinski | I'll have update prepared | 13:23:15 |
| Pol | In reply to @piotrkwiecinski:matrix.org
if I'm not mistaken 8.4 is scheduled for the next staging-next merge it has been merged this morning, so it's coming very soon. | 13:24:14 |
| piotrkwiecinski | Is this correct syntax ? | 13:27:59 |
| piotrkwiecinski | patches = lib.optional (lib.versionOlder version "8.4.0beta1") [
./fix-paths-php7.patch
] ++ lib.optional (lib.versionAtLeast version "8.4.0beta1") [
./fix-paths-php84.patch
] ++ extraPatches;
| 13:28:00 |
| piotrkwiecinski | if this works as expected i can PR it earlier | 13:28:50 |
| piotrkwiecinski | ok seems to build | 13:31:37 |
| Pol | no | 13:31:40 |
| Pol | By using lib.optional <predicate> [ ], you're wrapping twice. | 13:32:04 |
| Pol | In this case, you have to use lib.optionals <predicate> [ ] | 13:32:20 |
| Pol | (hense the s) | 13:32:28 |
| piotrkwiecinski | somehow it built without s too | 13:34:28 |
| piotrkwiecinski | and applied the patch | 13:34:40 |
| piotrkwiecinski | on I changed it to s | 13:35:53 |
| piotrkwiecinski | so in theory it shouldn't break current 8.4.0alpha1 | 13:36:21 |
| Pol | We can already use beta1 I think | 13:40:12 |
| piotrkwiecinski | we have alpha | 13:40:24 |
| Pol | beta1 : https://downloads.php.net/~calvinb/ | 13:40:45 |
| piotrkwiecinski | alpha4 | 13:40:47 |
| Pol | alpha4 and beta1 are available | 13:40:55 |
| piotrkwiecinski | in our repo i mean | 13:40:58 |
| Pol | ah ok | 13:41:02 |
| Pol | #324831 php84: init at 8.4.0alpha1 ✅ staging-next ✅ master ✅ nixos-unstable-small ⏳nixos-unstable ⏳nixpkgs-unstable | 13:42:41 |
| Pol | It will be soon available on nixos-unstable! | 13:42:54 |
| piotrkwiecinski | it's in master so I can PR update to beta | 13:43:56 |
