| 15 Apr 2023 |
 Pol | I'll fix this | 22:34:54 |
 tgerbet | * The only exception besides Phing in the list seems to be deployerphp/deploy but it seems it is only because the composer.lock was not removed from a previous iteration | 22:35:04 |
| Pol | Nice catch though | 22:36:42 |
| 16 Apr 2023 |
| Pol | In reply to @tgerbet:matrix.org
The only exception besides Phing in the list seems to be deployerphp/deploy but it seems it is only because the composer.lock was not removed from a previous iteration Job done. | 09:11:36 |
| Pol | In reply to @jtojnar:matrix.org
buildPhpProject would basically become stdenv.mkDerivation wrapper with composerSetupHook in nativeBuildInputs and setting composerDeps to the result of buildComposerVendorDir function, which the setup hook would then use So, the idea is to create a function for building only the vendor dir ? | 09:13:00 |
 Jan Tojnar | Pol: yup, so that it can also be used when buildPhpPackage cannot be used | 15:19:06 |
| Pol | Ok. Will do. | 15:36:26 |
| Pol | But that function will only do the `composer --download-only` then ? | 15:41:06 |
| Jan Tojnar | yup | 15:47:42 |
| Jan Tojnar | Pol: look at cargoSetupHook for an example: https://nixos.org/manual/nixpkgs/stable/#python-package-using-setuptools-rust | 15:47:59 |
| Jan Tojnar | cargoSetupHook does the second part | 15:48:26 |
| Jan Tojnar | * Pol: look at fetchCargoTarball for an example: https://nixos.org/manual/nixpkgs/stable/#python-package-using-setuptools-rust | 15:48:48 |
| Pol | Ok. Will try. | 15:50:30 |
| Pol | In reply to @jtojnar:matrix.org
cargoSetupHook does the second part Do we need bash scripts just like for cargoSetupHook ? | 16:29:26 |
| Jan Tojnar | yup | 16:29:53 |
| Jan Tojnar | basically just extract the stuff you have in phases now | 16:30:17 |
| Pol | I'm not at ease with that yet | 16:32:14 |
| Pol | I'm failing to see the big picture | 16:32:25 |
| Pol | Do you mind helping me on that part? | 16:32:35 |
| Pol | I can grant you access to the PR if you want to. | 16:32:49 |
| Pol | 
Download image.png | 16:40:24 |
| Pol | Is this is what you have in mind? | 16:40:29 |
| Pol | With something like this? | 16:44:53 |
| Pol | 
Download image.png | 16:44:56 |
| Jan Tojnar | Pol: for simplicity, you could have a single composerSetupHook on Nixpkgs level | 17:11:31 |
| Jan Tojnar | and then have configure, build and install functions that would replace configurePhase, buildPhase and installPhase respectively | 17:12:14 |
| Jan Tojnar | plus a second function that would create the vendor variable | 17:13:17 |
| Jan Tojnar | * plus a second function that would create the vendor variable in your PR | 17:13:23 |
| Pol | right right, I'm trying but I can't get it working. I'll retry another day. Help is welcome on this. | 18:35:52 |
| 17 Apr 2023 |
| Pol | PHP Bumps: https://github.com/NixOS/nixpkgs/pull/226605 -> needs review/merge. | 08:37:41 |
