| 20 Aug 2024 |
 fsagbuya | The upstream package is only the base installation; however, these are good extensions to add for the Flarum package, and that is how we used it. I only added this in my local nixpkgs because some users may not want to enable it. I can push these packages if it's alright. Although, I'm thinking there might be a way to make this optional. | 09:19:34 |
| fsagbuya | In reply to @drupol:matrix.org
I think this is the way to go. Either that or a .patch. an optional .patch is a good idea too | 09:22:51 |
 Pol | composer doesn't have, like python, a way to compose groups of dependencies. | 09:41:45 |
| Pol | So I guess using a patch is the way to go. | 09:41:53 |
| Pol | I think the buildComposerProject2 will help this. | 09:42:06 |
| Pol | https://github.com/NixOS/nixpkgs/pull/308059 | 09:42:39 |
| fsagbuya | In reply to @drupol:matrix.org
So I guess using a patch is the way to go. Will try to add an optional patch upstream for the meantime until the buildComposerProject2 is merged. Thanks! | 09:46:18 |
| Pol | especially this: https://github.com/NixOS/nixpkgs/pull/308059/files#diff-bead697169711cba8bf1ffc5a302d4dbe3f7d72513c9043cd431aba2c885885bR41 | 09:47:25 |
 piotrkwiecinski | I reckon we should merge https://github.com/NixOS/nixpkgs/pull/308059 | 14:13:32 |
| piotrkwiecinski | and start using it in the wild | 14:13:42 |
| piotrkwiecinski | we can always improve it in the future | 14:14:20 |
| Pol | Done :) | 16:40:21 |
| Pol | Champagne! | 16:43:03 |
| Pol | You're motivated piotrkwiecinski ! | 17:53:13 |
| Pol | You were waiting that new builder since quite a while | 17:53:30 |
| piotrkwiecinski | I'll migrate a couple more tomorrow. I have a boring 1h meeting. I'll kill 2 birds with 1 stone | 17:54:55 |
| Pol | Okay :) | 17:55:09 |
| piotrkwiecinski | I'm slowly fixing php builds | 17:55:44 |
| piotrkwiecinski | 68 pass, 40 to go | 17:55:59 |
| Pol | Thank you once again!!! | 18:05:10 |
| Pol | piotrkwiecinski: Looks like the issue is in the autoloader generation in Composer... | 21:32:05 |
| Pol | 
Download image.png | 21:32:10 |
| 21 Aug 2024 |
| fsagbuya | In reply to @drupol:matrix.org
Done :) Cheers! Will try this soon to replace the changes in this PR: https://github.com/NixOS/nixpkgs/pull/336044, likely when it's already available in the unstable branch. | 02:19:50 |
| piotrkwiecinski | Pol: I reckon it's caused by --optimize-autoloader | 06:50:01 |
| piotrkwiecinski | I removed it from composer-vendor-hook.sh and I get the same hash every run. At least at the moment. | 06:52:15 |
| piotrkwiecinski | Adding sort in both places maybe will help:
https://github.com/composer/composer/blob/main/src/Composer/Autoload/AutoloadGenerator.php#L268
https://github.com/composer/composer/blob/main/src/Composer/Autoload/AutoloadGenerator.php#L280
| 07:09:01 |
| Pol | In reply to @fsagbuya:matrix.org
Cheers! Will try this soon to replace the changes in this PR: https://github.com/NixOS/nixpkgs/pull/336044, likely when it's already available in the unstable branch. Wait a bit, we identified an issue in the buildComposerProject2. We need to fix it asap before promoting the new builder. | 07:33:21 |
| piotrkwiecinski | Pol: | 18:37:55 |
| piotrkwiecinski | * Pol: I'm doing some digging into composer issue | 18:38:06 |
| piotrkwiecinski | These paths are part of PSR4 logic | 18:39:01 |
