| 13 Aug 2024 |
piotrkwiecinski | Which languages are you going to use? | 18:19:55 |
@drupol:matrix.org | At the very end of June, my manager announce me that the PHP Competency Center, the team where I was working in, was about to be dissolved. That means that nobody is maintaining PHP in my team anymore. | 18:20:05 |
@drupol:matrix.org | I had 2 choices | 18:20:10 |
@drupol:matrix.org |
- I would stop working for E.C.
| 18:20:23 |
@drupol:matrix.org |
- I would find another place where I could develop my skills
| 18:20:33 |
@drupol:matrix.org | I chose option 2. | 18:20:41 |
@drupol:matrix.org | I'm now an architect, develloping a python backend for a very cool app involving A.I. | 18:21:22 |
@drupol:matrix.org | So, exit PHP. | 18:21:29 |
@drupol:matrix.org | Welcome Python. | 18:21:53 |
piotrkwiecinski | From elephant to snake | 18:22:13 |
@drupol:matrix.org | haha nice ! :D | 18:22:43 |
@drupol:matrix.org | I will reuse it :D | 18:22:48 |
piotrkwiecinski | I updated comments in https://github.com/NixOS/nixpkgs/pull/334411 | 18:22:57 |
@drupol:matrix.org | I have a question for you with these patches. | 18:23:43 |
@drupol:matrix.org | you know I'm maintaining that thingie here: https://github.com/loophp/php-src-nix/ | 18:24:02 |
@drupol:matrix.org | Basically this project automatically maintain itself. I like it. | 18:24:13 |
@drupol:matrix.org | However, I noticed sometimes that when we set lower bounds for patches in nixpkgs, it sometimes makes issue in my project. | 18:24:37 |
@drupol:matrix.org | So I was wondering if you correctly set the version boundaries so it can be cleanly applied to the PHP versions we maintain in nixos/nixpkgs but also in my project. | 18:25:15 |
piotrkwiecinski | My fix should apply to all php8.1 versions | 18:25:50 |
@drupol:matrix.org | As you can see, it's quite broken: https://github.com/loophp/php-src-nix/actions/runs/10364035720 | 18:25:54 |
@drupol:matrix.org | Oh damn, I just notice now that we will have an issue with the next PHP84 version... https://github.com/loophp/php-src-nix/actions/runs/10364035720/job/28688711194 | 18:26:47 |
@drupol:matrix.org | In reply to @piotrkwiecinski:matrix.org My fix should apply to all php8.1 versions Cool, I validate your PR then. | 18:27:06 |
@drupol:matrix.org | Done. | 18:27:33 |
piotrkwiecinski | also is it ok to go to master? | 18:28:30 |
piotrkwiecinski | it has fair bit of rebuilds | 18:28:36 |
@drupol:matrix.org | yes master is fine. | 18:29:01 |
piotrkwiecinski | > calling 'postUnpack' function hook '_updateSourceDateEpochFromSourceRoot'
> Running phase: patchPhase
> applying patch /nix/store/r2bw91ma55jqnlv51iwck17f05i1c76x-fix-paths-php7.patch
> patching file ext/gettext/config.m4
| 18:29:07 |
piotrkwiecinski | this one is in generic.nix | 18:29:16 |
@drupol:matrix.org | yes, since quite a while | 18:30:15 |
piotrkwiecinski | https://github.com/php/php-src/commit/c2d6edc4854b036a94e28b495ccbc1b652649b02 | 18:57:21 |