| 21 Dec 2022 |
 Jan Tojnar | and while the phars mostly just contain PHP code in text form so it is not really bytecode either, it ends up being run by an interpreter | 18:12:19 |
 Pol | Jan Tojnar: I can update it asap. Ok for you as well etu ? | 18:18:47 |
| Jan Tojnar | Pol: probably better to ask ris first | 18:19:18 |
| Pol | Redacted or Malformed Event | 18:25:14 |
| 24 Dec 2022 |
| Pol | Merry Christmas all ! | 18:37:33 |
| Pol | I just submitted a new PR here : https://github.com/NixOS/nixpkgs/pull/207605 | 18:37:44 |
| Pol | pr to merge | 21:24:33 |
| Pol | https://github.com/NixOS/nixpkgs/pull/207088 | 21:24:36 |
| 25 Dec 2022 |
|  ahmed left the room. | 10:34:42 |
| Pol | Another PR to merge: https://github.com/NixOS/nixpkgs/pull/207605 | 19:06:27 |
| Pol | I added for each files modified:
passthru = {
updateScript = nix-update-script {
attrPath = "php.packages.<name>";
};
};
| 19:08:36 |
| Pol | So we can update thos packages by doing: | 19:08:51 |
| Pol | nix-update -u --commit php.packages.composer | 19:09:08 |
| Pol | It's such a time saver ;) | 19:09:17 |
| Pol | Hope you'll be ok with those changes. | 20:31:31 |
| Pol | basically, this implies that packages and extensions can be updated by using nix-update without editing files manually | 20:32:02 |
| 26 Dec 2022 |
| Pol | Jan Tojnar: I just submitted this to fix flake.lock update which is currently broken: https://github.com/fossar/nix-phps/pull/189 | 21:34:03 |
| 27 Dec 2022 |
| Pol | Jan Tojnar: Your point of view on this? https://github.com/NixOS/nixpkgs/pull/207605 | 09:19:07 |
| Pol | etu, aanderse ? ^^ | 13:38:32 |
| Pol | * etu, aanderse, talyz ? ^^ | 13:38:38 |
| Pol | I just updated the PR https://github.com/NixOS/nixpkgs/pull/207605 based on Jan Tojnar's feedback. It's ready for another round of review ! | 21:35:20 |
| 28 Dec 2022 |
 tgerbet | I made a few comments, mainly to fix the build and to have version numbers consistent with the rest of nixpkgs. | 20:16:57 |
| tgerbet | * I made a few comments, mainly to fix the build of the gnupg extension and to have version numbers consistent with the rest of nixpkgs. | 20:19:22 |
|  phaer joined the room. | 21:11:03 |
| 29 Dec 2022 |
| Pol | tgerbet: I was wondering how you found out that thing with gnupg ! In the meantime, I fixed all the suggestions. It's ready for another round of reviews. | 08:42:22 |
| tgerbet | I saw the submodule in the repo while checking the new source URLs so it was not too hard to find once the failures with nixpkgs-review | 10:34:43 |
| Pol | Nice :) | 10:35:04 |
| Pol | Submodules is the only thing I try to avoid using in Git... so I never think about that. | 10:35:24 |
| tgerbet | I'm doing some tests with the PR, if everything looks fine I will merge it.
It touches a lot of things so it will be painful/annoying if it stays open for too long and there is not a lot of risks. | 10:42:46 |
| Pol | Yep indeed. | 11:02:18 |
