| 24 May 2023 |
 @drupol:matrix.org | I also wrote Jordi by email, I hope I'll get a replu. | 15:52:01 |
| @drupol:matrix.org | * I also wrote Jordi by email, I hope I'll get a reply. | 15:52:04 |
| @drupol:matrix.org | I also have issues on Darwin: https://logs.ofborg.org/?key=nixos/nixpkgs.225401&attempt_id=fe475da1-6c83-40ff-acf0-f233f89db280 | 15:52:46 |
| @drupol:matrix.org | There is something that provoque a different hash, I just can't seem to find the reason yet. | 15:53:16 |
| @drupol:matrix.org | If anyone running a Mac is around, it would be helpful. | 15:53:26 |
| @drupol:matrix.org | I think I have the reason... fix on its way. | 16:01:37 |
| @drupol:matrix.org | Issue fixed on Darwin, I guess we're back to green state now. https://github.com/NixOS/nixpkgs/pull/225401/checks?check_run_id=13732635188 | 17:20:22 |
| @drupol:matrix.org | I'll rewrite the documentation tonight. | 17:32:15 |
| @drupol:matrix.org | We have a huge thread indeed, my bad. | 17:34:43 |
| @drupol:matrix.org | This thread is related to the new PHP builder. | 17:34:53 |
| @drupol:matrix.org | * This thread is related to the new PHP builder for Nix. | 17:34:57 |
| @drupol:matrix.org | Maybe I should not use it if it creates sync issues. | 17:35:09 |
| 25 May 2023 |
| @drupol:matrix.org | PR back to green state: https://github.com/NixOS/nixpkgs/pull/225401 | 06:26:05 |
| @drupol:matrix.org | Feel free to review and/or contribute to it ! | 06:26:36 |
| @drupol:matrix.org | I refactored the plugin to use the Composer API correctly to download and install the packages. It works even better :) | 10:08:32 |
| @drupol:matrix.org | I just made a diagram on how the new PHP wrapper is working: https://planttext.com/api/plantuml/png/bLLBRzim3BxhLn3jRKMB9iqfXw4lh1dMROQ1xgx8RC9QbZn9JkD_F_eHFvgqpN9HGl8ZFtuIcMiVf0j5feK853J2Bzf2j8ZWjY2Te1DAve6iWMTQ5GvXCeU5VGKAy6fTwiKQPHKLMGttgBKaT5AWILgxa4MmfiYM_DsdP7BfP0OHboH5kJGXaab2PWNJou7_rcuFsdqecQ4FZbHDUU31lmKQXJ_HUxd26qqh0uvMwo2a2jOnkGsSwihmu12D44kxXPDbrUIvibbkFRhptDaNLE72qFO4JX-RQ5cAlESBDGIaX-WIJdyxQLOuyk-IVJUihDPtrZJABQnDQzZa65YjVWUP7bLfZIhj85V7GDgZ0yqw4DyWi4A7PNB89x6gvL2fMrtWOQNYZvMAktHxOiKVYzKZttGI7-ZaHWNQo83xJw4od7-jBlJihCC9_baRvsqZkw8_iFJlEXSsmtjohJ_Uy_UCXOZ7zU86CXaPfUwxVRGg1V8WDvAqN6eKm1y6rB0vtDcyh0OpM525SyX29UHGrTLOXWFPClAUfsoOY2b_u_ny2Gt6OIYSwUZDnfndZN4E3sXuybbTRPNKNHNetyeWk6PgYv0N0SX0M3ThntCOzXMRyw1qhVplQzK7ZtgC9hjh6_NukSejy2YL-rYrpcn_znTVU8bgz7s7RHlJyRkRDiQ1ffaqz8m-r7Z8fKfvn_cB5s_D83n6jPkVlkQRcASyaQ7QgxfgiqvdZIxtA5sDALqrnZdyaPgIYjAe04WpQBDAlPTm_6wYMMESGpkua63Eul4A9nQeTyUOsSqd0dJ1dLw-p3IPrCCpR_ub6Ud6MV_d_GbnpSIgVvj_ | 14:43:58 |
| @drupol:matrix.org | The Composer plugin has been refactored today and there has been a lot of improvements. | 19:57:22 |
| @drupol:matrix.org | The PHP builder is now using it (https://github.com/NixOS/nixpkgs/pull/225401) and thanks to the plugin, the Nix hooks has been streamlined as well. | 19:58:01 |
| @drupol:matrix.org | I'm still looking for people to review and provide some feedback | 19:58:22 |
| 26 May 2023 |
| @drupol:matrix.org | Sometimes I wonder why we are making this... | 16:08:51 |
| @drupol:matrix.org | With such a thing: https://gist.github.com/drupol/94f7917d22f37affe104a68ceb96f019 I can do a reproducible build of Drupal. | 16:09:04 |
| @drupol:matrix.org | So I'm wondering if all the work I did on the PR worth it. | 16:09:18 |
| @drupol:matrix.org | Jan Tojnar: Is this kind of derivation allowed in nixpkgs ^^ | 16:09:31 |
| @drupol:matrix.org | This is not an IFD, this is a FOD... but it's reproducable... totally. | 16:09:55 |
| @drupol:matrix.org | This is putting at stake everything I worked on on the PHP builder. | 16:20:15 |
 tgerbet | You want to split the retrieval part and the part where Composer generates code to limit the chances of breaking the FOD when upgrading Composer.
| 16:23:44 |
| @drupol:matrix.org | That's an important point, thanks. | 16:24:16 |
| @drupol:matrix.org | I have hard time explaining what I think about this in english. IMHO, what I did in this PR is as fragile as what we do in that Drupal derivation. | 16:26:07 |
| @drupol:matrix.org | In that example derivation, I only rely on Composer. In the PR, I rely on Composer + custom plugin. | 16:26:37 |
| @drupol:matrix.org | If i had to choose, I would definitely prefer to only rely on Composer. | 16:26:52 |
