| 12 Jun 2023 |
Pol | True, but I have no clue on how to integrate that. | 17:33:41 |
Pol | Do you think adding a composerHome input to composer derivation is a good idea? | 17:34:01 |
Pol | I just pushed the changes for the composer keys ! https://github.com/NixOS/nixpkgs/pull/225401/commits/9e1540b6f6f7055af9710aa1c8c83b9966953cce | 17:34:24 |
tgerbet | In reply to @drupol:matrix.org Do you think adding a composerHome input to composer derivation is a good idea? Probably not, it will break too many things (e.g. access to GH OAuth access token) | 17:38:55 |
Pol | Mmhm I don't know | 17:40:15 |
tgerbet | It looks like we only get those warnings/errors because we are using the phar and in this situation it expects to be able to upgrade itself https://github.com/composer/composer/blob/bbea3e5284fd859373c292c7f696f9647f9a59ef/src/Composer/Command/DiagnoseCommand.php#L152 | 17:41:33 |
Pol | Actually, we can reproduce the same issue with the src version, let me do a poc | 17:42:25 |
Pol | Oh no you're right | 17:43:34 |
Pol |  Download image.png | 17:43:37 |
Pol | It only does that with the PHAR indeed. | 17:43:45 |
Pol | So sad it doesnt use proper XDG standard. | 17:44:29 |
Pol | So we could install those keys in a specific place and be done with it. | 17:44:44 |
tgerbet | Yep. Since it is more of a Composer issue than something related to the plugin I would just let not bother with the keys in the plugin. It's not like a composer diagnose will be issue while building the PHP packages 😄 | 17:53:16 |
Pol | I just wanted to be just pixel perfect... "just in case of... " | 17:58:04 |
tgerbet | Unpacking the phar archive seems to work https://github.com/NixOS/nixpkgs/pull/237410 | 19:02:36 |
Pol | Let me be completely honest with this | 19:21:23 |
Pol | I don't think we should do that... | 19:21:36 |
Pol | I believe we should let the phar untouched. | 19:21:56 |
Pol | If something has to be fixed, it's in Composer, not in here | 19:22:12 |
Pol | Let me comment in the PR so we can continue there. | 19:23:51 |
Pol | tgerbet: Hope no hard feeling on this | 20:02:10 |
Pol | * tgerbet: Hope no hard feelings on this | 20:02:14 |
tgerbet | Oh no | 20:02:26 |
tgerbet | Completely fine :) | 20:02:41 |
| 13 Jun 2023 |
| @marcus_yallow:matrix.org joined the room. | 13:15:02 |
| 14 Jun 2023 |
| hexa left the room. | 16:15:06 |
| 15 Jun 2023 |
Shyim | As someone packaged already PHP 8.3alpha? :) | 21:20:18 |
tgerbet | Pol has tried but it encountered some issues. I did not had time to give it a try yet | 21:26:21 |
Pol | => https://github.com/php/php-src/issues/11408 | 21:27:01 |
Pol | Jan Tojnar: | 21:27:06 |