| 19 Apr 2023 |
 Shyim | I packaged Roadrunner for Nix. Looking for reviewers :) https://github.com/NixOS/nixpkgs/pull/227144 | 21:41:57 |
| 21 Apr 2023 |
 @drupol:matrix.org | Hey PHP !
Yesterday I finally made the changes in this PR https://github.com/NixOS/nixpkgs/pull/225401 to enable hooks.
That was quite complicated for me since I was not aware of those hooks in Nix overall, so, a lot of back and forth with some community members to tell me where to look for.
The PR has been updated with those hooks now and it works like before.
There is only one derivation which is broken "#wp-cli". Apparently, it requires wrapProgram in its postInstall hook, but it cannot find it despite it is in nativeBuildInputs. I guess it's a minor issue, but I'll make a pause today on that thing because I've been spending too much time on it lately.
Feel free to try the branch and eventually help me with that wp-cli derivation!
Enjoy your friday all ! | 07:25:39 |
| @drupol:matrix.org | Thanks Jan Tojnar going to try your suggestion ! | 07:32:09 |
| @drupol:matrix.org | Thanks, it fixed the issue :) | 07:39:47 |
| @drupol:matrix.org | You're amazing, thanks ! | 07:39:51 |
| @drupol:matrix.org | PR is back to green ! :) | 07:52:29 |
 Jan Tojnar | Pol: you will also want to do previousAttrs.buildPhase or ''runHook ...'' for the phases | 07:54:01 |
| @drupol:matrix.org | Oooh ! you're right. | 07:54:16 |
| @drupol:matrix.org | As usual. | 07:54:17 |
| @drupol:matrix.org | Going to do it now. | 07:54:20 |
| Jan Tojnar | the empty phases are a bit ugly but I do not see a way around them | 07:55:01 |
| @drupol:matrix.org | We could override them in the composer-setup-hook.sh I guess? | 07:55:26 |
| @drupol:matrix.org | Instead of hooking on preConfigurePhase, we override the phase itself ? | 07:55:46 |
| Jan Tojnar | yes, but then if people pass configurePhase to buildPhpProject, they will lose the setupHook | 07:56:31 |
| Jan Tojnar | * yes, but then if people pass configurePhase to buildPhpProject, they will lose the setupHook functionality | 07:56:46 |
| Jan Tojnar | unless they call it explicitly | 07:57:02 |
| Jan Tojnar | which maybe would not be a problem if documented. IDK, we are breaking a new ground so the usage patterns are not developed yet. | 07:57:53 |
| Jan Tojnar | * which maybe would not be a problem if documented. IDK, we are breaking a new ground so the usage patterns are not well developed yet. | 07:58:11 |
| @drupol:matrix.org | Job done. Fixed. | 07:59:35 |
| Jan Tojnar | and also strictDeps`` | 08:05:24 |
| Jan Tojnar | * and also strictDeps | 08:05:30 |
| Jan Tojnar | it really shows that mkDerivation was not designed with this in mind | 08:06:28 |
| @drupol:matrix.org | So, something like that? | 08:07:16 |
| @drupol:matrix.org | installPhase = (previousAttrs.installPhase or ''
runHook preInstall
runHook postInstall
'');
| 08:07:27 |
| @drupol:matrix.org | Is this what you advise me to do in your last comment on Github ? | 08:07:39 |
| Jan Tojnar | yes | 08:11:23 |
| Jan Tojnar | no need for the parens | 08:11:34 |
| @drupol:matrix.org | Oki | 08:12:09 |
| @drupol:matrix.org | Job done. Fixed. | 08:16:37 |
| Jan Tojnar | looks good at a glance now | 08:26:19 |
