| 21 Mar 2023 |
Lars Strojny | Just that I have a wider line width configured | 19:40:44 |
Pol | Ok you already have a formatter then | 19:43:35 |
Pol | Oooh you changed to nixfmt | 19:44:08 |
Pol | I missed that | 19:44:10 |
Pol | All good then :) | 19:44:13 |
| 23 Mar 2023 |
Pol | Are you ok to merge this? https://github.com/NixOS/nixpkgs/pull/221845 | 07:53:20 |
Lars Strojny | In reply to @drupol:matrix.org Are you ok to merge this? https://github.com/NixOS/nixpkgs/pull/221845 If you ask me, yes. Discussed the issue off band with Jan and he was also fine | 12:55:48 |
Pol | yep, it was merely to let other maintainers know about the PR :) | 13:04:02 |
Pol | I'm also ok to merge it | 13:04:07 |
| 27 Mar 2023 |
Pol | PHPBench, init at 1.2.10 : https://github.com/NixOS/nixpkgs/pull/223365 Ready for review! | 09:27:44 |
| 28 Mar 2023 |
Pol | ^^ | 06:21:33 |
Gaël Reyrol | I know PHP 7.4 is deprecated but PHPBench is still supporting it, is it on purpose you decided to directly use PHP 8.0 ? | 07:40:48 |
@etu:failar.nu | We don't have php74 in nixpkgs | 08:05:52 |
@etu:failar.nu | The reason we drop it right after the XX.11 release is that it gives time to figure out everything that breaks of the removal before the XX.05 release 🙂 | 08:07:06 |
@etu:failar.nu | Then we also bump the default PHP used right after the XX.05 release to figure out what breaks before the XX.11 release 🙂 | 08:08:47 |
philipp | Also PHP 7.4 isn't just deprecated. It's eol. What is deprecated is php 8.0 | 08:13:33 |
@etu:failar.nu | So PHP 8.0 will be dropped May or so just to find breaking points. :) | 08:15:21 |
@etu:failar.nu | * The reason we drop it right after the XX.05 release is that it gives time to figure out everything that breaks of the removal before the XX.11 release 🙂 | 08:15:36 |
Pol | What's wrong with what I did ? | 09:07:49 |
philipp | I actually think that it would be better to use php in the function header and then set the version in callPackage is a better way to do it. Also I wouldn't overwrite the php version away from the global default in nixpkgs (php81) unless there is a specific reason to do it. | 09:14:57 |
philipp | I put my remarks in the nixpkgs pr where they belong... | 09:17:11 |
Pol | Nice, very good idea. | 09:37:25 |
Pol | I also replicated that in n98-magerun | 09:37:33 |
Pol | The commit is also inside that PR, I guess it's not an issue. | 09:37:46 |
Pol | https://github.com/NixOS/nixpkgs/pull/223365 | 09:37:49 |
Gaël Reyrol | Pol: there is nothing wrong, etu kind of headed where I wanted to but I wasn't enough explicit! | 09:57:32 |
Pol | oki | 09:58:28 |
Pol | philipp: Feel free to let me know if it's better now | 13:29:29 |
| 29 Mar 2023 |
Pol | Hey PHPers, I checked how a Rust package is packaged in NixOS. Rust packages are similar to PHP, it contains Cargo files. One of those two files is Cargo.lock which is used to lock the dependencies, just like composer.lock. Look how easy it is to package a Rust app: https://github.com/NixOS/nixpkgs/blob/master/pkgs/tools/typesetting/typst/default.nix
Do you think we can do something similar but for PHP ?
| 07:18:42 |
Pol | * Hey PHPers, I checked how a Rust package is packaged in NixOS. Rust packages are similar to PHP, it contains Cargo files. One of those two files is Cargo.lock which is used to lock the dependencies, just like composer.lock. Look how easy it is to package a Rust app: https://github.com/NixOS/nixpkgs/blob/master/pkgs/tools/typesetting/typst/default.nix
Do you think we can do something similar but for PHP ?
| 07:21:45 |