| 3 Oct 2022 |
 @drupol:matrix.org | Was it related to the class RandomNodeService of ramsey/identifier ? | 17:43:26 |
| @drupol:matrix.org | I guess this is the reason why you didn't do: | 17:43:36 |
| @drupol:matrix.org | 
Download image.png | 17:43:39 |
 @ramsey:matrix.org | Yes | 17:45:43 |
| @drupol:matrix.org | Ah right, so, you can discard my screenshot then :) | 17:46:02 |
| @ramsey:matrix.org | Well... sort of. It was about using that class within another class that's immutable | 17:46:03 |
| @drupol:matrix.org | Okay | 17:46:23 |
| @ramsey:matrix.org | It was about trying to designate the UUID factories as immutable, but I can't do that because I'm using that random service here: https://github.com/ramsey/identifier/blob/cd0fb1c321bf3c3c1fd418a3318f5904b3a8e9c3/src/Uuid/Factory/UuidV4Factory.php#L52 | 17:47:48 |
| @drupol:matrix.org | Oh... what's the best pattern there? | 17:49:23 |
| @ramsey:matrix.org | I don't know. It technically mutates the state of the randomizer on the machine, so the class can't be considered immutable | 17:49:53 |
| @ramsey:matrix.org | So, I removed the @psalm-immutable annotation 🙂 | 17:50:05 |
| @drupol:matrix.org | Having a look. | 17:50:40 |
| @drupol:matrix.org | It's weird because no property is being modified. | 17:51:10 |
| @ramsey:matrix.org | Right, but random_bytes() and random_int() mutate the state of the machine | 17:51:32 |
| @ramsey:matrix.org | so, the class performs mutating operations | 17:51:48 |
| @drupol:matrix.org | Yeah but you do not modify the class itself, so psalm shouldn't complain IMHO | 17:52:06 |
| @drupol:matrix.org | Going to make some experimentations :) | 17:52:17 |
| @ramsey:matrix.org | Psalm complains because an immutable class shouldn't mutate state anywhere (internally or externally) | 17:52:36 |
| @drupol:matrix.org | Maybe you should not create the $bytes variable there, just pass the random service to Binary::applyVersionAndVariant | 17:53:58 |
| @drupol:matrix.org | Something like that? | 17:54:35 |
| @drupol:matrix.org | 
Download image.png | 17:54:37 |
| @ramsey:matrix.org | it would still be mutating the state of the machine when it creates the bytes in applyVersionandVariant() | 17:54:44 |
| @drupol:matrix.org | mmh | 17:54:50 |
| @ramsey:matrix.org | You'd have to create the bytes outside the class and then pass them into the class in order to keep the class immutable | 17:55:25 |
| @drupol:matrix.org | True. | 17:55:36 |
| @drupol:matrix.org | You have to leave it to the user | 17:55:44 |
| @ramsey:matrix.org | but that's a cumbersome API, so I'll just not put @psalm-immutable on the class 🙂 | 17:55:52 |
| @drupol:matrix.org | True. | 17:55:58 |
| @drupol:matrix.org | And doing this? | 17:57:02 |
| @drupol:matrix.org | 
Download image.png | 17:57:03 |
