| 9 Nov 2022 |
 Pol | nice finding | 14:50:15 |
 Jan Tojnar | maybe we should just drop the mkDerivation | 18:21:24 |
| Jan Tojnar | I do not really see a point prefixing the package name with php https://github.com/ilkecan/nixpkgs/commit/06e0ede06ec1b2e97637b93e2b00c1eb9c71d3a6 | 18:21:43 |
| 10 Nov 2022 |
| Pol | We need senior review here: https://github.com/NixOS/nixpkgs/pull/198470 | 13:01:35 |
| Pol | It modifies the PHP stuff | 13:01:44 |
| 11 Nov 2022 |
 ma27 | friendly ping re the PR linked above, would be cool to get some more reviewers on that :) | 22:43:16 |
| 12 Nov 2022 |
| Pol | Thanks etu! | 08:01:57 |
 @etu:failar.nu | Pol: I was thinking about this NTS/ZTS thing | 10:08:31 |
| Pol | yep | 10:08:39 |
| Pol | me too :) | 10:08:42 |
| @etu:failar.nu | Why is it depending on isDarwin? | 10:08:57 |
| @etu:failar.nu | Is it because ZTS doesn't work on darwin or something like that? | 10:09:15 |
| Pol | No, zts was mostly used because of mod_php on apache | 10:09:47 |
| @etu:failar.nu | Then it's weird that it depends on isDarwin 😛 | 10:10:24 |
| @etu:failar.nu | So we would want... NTS by default, right? | 10:19:46 |
| @etu:failar.nu | And then maybe a separate attribute name for php with ZTS | 10:19:58 |
| @etu:failar.nu | like mod_php80 mod_php81 mod_php or something? And then use that by default for apache. | 10:20:46 |
| Pol | yes | 10:21:45 |
| @etu:failar.nu | Pol: You feel up for doing those changes to your draft? | 10:28:42 |
| @etu:failar.nu | Pol: And yeah, stop make it depending on isDarwin | 10:28:56 |
| Pol | I can try :) | 10:48:57 |
| Pol | Job done etu ! https://github.com/NixOS/nixpkgs/pull/194172 | 21:57:31 |
| Pol | I like the change | 21:57:37 |
| @etu:failar.nu | My thinking is, why over complicate it with new attributes and all. Apache users are used to that it needs building (that could be improved as a separate thing) and the unit test for Apache well just work since it enables the Apache module and changes the required parameters. | 21:59:37 |
| @etu:failar.nu | It should probably end up in the change log for the upcoming release though | 22:00:13 |
| Pol | yup | 22:19:43 |
| Pol | I'll take care of the changelog tomorrow | 22:24:03 |
| 13 Nov 2022 |
| Pol | I just created a draft PR so that we can merge PHP 8.2.0 as soon as it is out (8th December): https://github.com/NixOS/nixpkgs/pull/201000 | 09:37:17 |
| Pol | I don't know if we can submit a RC though. | 09:42:26 |
| Pol | Because if we can, that PR is definitely valid. | 09:42:35 |
