| 28 Apr 2022 |
ramsey | Yep. Looks like configure couldn’t find it, and it’s also not in the options provided to configure | 17:29:31 |
Pol | checking for OpenSSL support... yes
checking for openssl >= 1.0.2... yes
checking for phar openssl support... no
| 17:41:19 |
Pol | I'm progressing. | 17:41:22 |
Pol | No I need to find how to enable "phar openssl support" | 17:41:33 |
Pol | Do you know what is the flag to enable this? ramsey ? | 17:52:05 |
Pol | Tried on Google, but couldn't find anything relevant yet. | 17:53:48 |
etu | In reply to @drupol:matrix.org etu: Could you review this? https://github.com/NixOS/nixpkgs/pull/170614 Question: Does the usage of this package actually depend on which version of PHP it's wrapped with? | 18:54:37 |
Pol | Jan Tojnar: I'm trying to fix this issue and I notice something. | 18:07:33 |
Pol |
- In here: https://github.com/fossar/nix-phps/blob/php-master/pkgs/phps.nix#L438 curl is enabled.
- When I try to build
php-master: nix build --override-input php-src github:php/php-src/PHP-8.1 -L .#php-master
- Then it fails
- Then I check the logs:
nix log /nix/store/azipihspd62sqzdlhgyg5y2kyfp81xpx-php-8.1.7.pre+date=20220427181447.drv | grep -i 'curl' | less
| 18:08:55 |
Pol | The output is: | 18:08:58 |
Pol | checking for cURL support... no | 18:09:08 |
Pol | How is it possible? | 18:09:14 |
Pol | Normally, curl should be enabled since curl extension is in the list of php-master derivation. | 18:14:46 |
ramsey | Do you have the —enable-phar option? | 18:25:15 |
ramsey | I don’t know about any options to enable openssl support with phar. I thought it was automatic | 18:27:53 |
Pol | In reply to @etu:semi.social Question: Does the usage of this package actually depend on which version of PHP it's wrapped with? I don't know, I checked but it's not in the documentation. I think you should add it as it is and focus on a refactoring and update all the packages at once. | 19:01:15 |
Pol | WDYT ? | 19:03:34 |
etu | In reply to @drupol:matrix.org I don't know, I checked but it's not in the documentation. I think you should add it as it is and focus on a refactoring and update all the packages at once. I don't agree since that would mean that it would break the configuration for people who just started using it. Just because a tool is written in PHP doesn't automatically make it valid to package it three times, once for every version of PHP we support. If it's a tool that doesn't care about PHP version it doesn't belong in php.packages, if it cares, like composer for example. It absolutely belongs there. | 21:26:51 |
Pol | In reply to @etu:semi.social Question: Does the usage of this package actually depend on which version of PHP it's wrapped with? It does not, I just checked. Do you want me to move the package to some other places? | 19:33:22 |
etu | Yes. | 21:30:24 |
Pol | In reply to @etu:semi.social I don't agree since that would mean that it would break the configuration for people who just started using it. Just because a tool is written in PHP doesn't automatically make it valid to package it three times, once for every version of PHP we support. If it's a tool that doesn't care about PHP version it doesn't belong in php.packages, if it cares, like composer for example. It absolutely belongs there. True. Will make the change tomorrow morning, I'm already in bed. | 21:30:27 |
| 29 Apr 2022 |
etu | In reply to @drupol:matrix.org True. Will make the change tomorrow morning, I'm already in bed. But I like your suggestion to move out packages that doesn't depend on different versions, so I'd say that would be worth doing after the new release branch is branched off :) | 07:06:34 |
Pol | In reply to @etu:semi.social I don't agree since that would mean that it would break the configuration for people who just started using it. Just because a tool is written in PHP doesn't automatically make it valid to package it three times, once for every version of PHP we support. If it's a tool that doesn't care about PHP version it doesn't belong in php.packages, if it cares, like composer for example. It absolutely belongs there. Fixed ! https://github.com/NixOS/nixpkgs/pull/170614 | 07:50:07 |
etu | In reply to @drupol:matrix.org Fixed ! https://github.com/NixOS/nixpkgs/pull/170614 The commit message should now be: pdepend: init at 2.10.3 | 07:58:55 |
Pol | oops. You're right. | 07:59:04 |
Pol | Fixing it right now. | 07:59:11 |
Pol | Job done. | 07:59:31 |
ramsey | Pol: did you solve the PEAR installation issue | 19:17:48 |
Pol | ramsey: yes, I succeeded to build using --without-pear ! The rest of the issue is related to directory naming, something I guess related to Nix. | 19:49:02 |
ramsey | Interesting. I believe if you use --without-pear, the pecl installer tool will not be available, so PECL extensions have to be manually installed. | 19:49:41 |