| 4 May 2022 |
 Pol | etu: Is this one good enough as well?https://github.com/NixOS/nixpkgs/pull/170614 | 13:26:21 |
 etu | In reply to @drupol:matrix.org
etu: Is this one good enough as well?https://github.com/NixOS/nixpkgs/pull/170614 I found one thing interesting with that one, you link the homepage in the description, then you link the github page as the field homepage in the meta attribute 😉 | 13:28:10 |
| Pol | Yeah it's intented. | 13:28:29 |
| Pol | I prefer to link the github repo than a webpage | 13:28:39 |
| Pol | Nothing escape your eyes :D | 13:28:56 |
| etu | Many project websites are quite useless indeed | 13:29:08 |
| etu | A github project is often more useful | 13:29:17 |
| Pol | definitely | 13:29:21 |
| etu | Ah, yes, you had the attribute name php74Packages.pdepend in the commit message as well, should be pdepend since it's not part of the phpPackages attribute | 13:30:44 |
| Pol | omg. | 13:34:10 |
| Pol | Fixing this now. | 13:34:13 |
| Pol | Job done etu ! | 13:38:09 |
| Pol | Thanks etu ! | 13:50:22 |
|  An exploring bot joined the room. | 15:03:11 |
| An exploring bot left the room. | 15:03:12 |
| 7 May 2022 |
 Jan Tojnar | anyone can review https://github.com/NixOS/nixpkgs/pull/170962? | 15:35:56 |
| 9 May 2022 |
| Pol | PR to review:
- https://github.com/NixOS/nixpkgs/pull/170962 <- Needed to provide a PHP built from source.
| 12:32:45 |
| Pol | Merged !! ^^ | 16:27:14 |
| Pol | Jan Tojnar: What is this issue? https://github.com/fossar/nix-phps/runs/6357683823?check_suite_focus=true Where does it comes from ?! | 19:20:00 |
| Jan Tojnar | Pol: that is phpize not setting the RE2C or BISON make variables | 19:21:21 |
| Jan Tojnar | * Pol: that is phpize-generated configure script not setting the RE2C or BISON make variables | 19:21:44 |
| Pol | arghf**k | 19:21:56 |
| Pol | Is it a new patch to do for nix-phps or nixpkgs ? | 19:22:14 |
| Jan Tojnar | as explained here https://github.com/fossar/nix-phps/pull/104#issuecomment-1113964195 | 19:22:42 |
| Pol | Aaaah I do remember now. | 19:23:06 |
| Jan Tojnar | technically, Nixpkgs is affected too, only they do not notice because the tarballs already contain the generated files | 19:23:46 |
| Pol | Maybe we should fix it in nixpkgs directly | 19:24:07 |
| Pol | WDYT ? | 19:24:31 |
| Jan Tojnar | yeah, probably test here first and then move the fix to Nixpkgs like we did with the readline issue | 19:25:31 |
| Pol | Right, so the battleplan is to add those variables and that's it? | 19:26:19 |
