| 24 Apr 2022 |
 Pol | And just for the sake of it, I'm trying to fix the issue. | 15:48:14 |
 hexa |
The following versions are currently supported:
| 15:48:30 |
| hexa | where supported implies something very weird. | 15:48:40 |
| Pol | We should update the README file, for sure. | 15:49:57 |
| Pol | Here's the problem with PHP 7.2: https://dpaste.org/OgXgA | 19:07:40 |
| Pol | It seems to be an issue in the intl extension. | 19:07:52 |
| Pol | I cannot figure out what's the issue. | 19:08:02 |
| Pol | The issue only happen on MacOS. | 19:08:09 |
| 25 Apr 2022 |
| Pol | etu: The pull request for adding PlatformSH has been recreated here: https://github.com/NixOS/nixpkgs/pull/170065 would be nice to have your input ! | 07:33:16 |
 etu | :) | 07:52:26 |
| etu | Yeah, it made more sense to not have it in PHP packages since it doesn't matter which PHP version it uses | 07:52:46 |
| etu | At least compared to something like composer where it matters a lot which extensions and php version it runs on | 07:53:16 |
| Pol | I agree ! | 07:53:28 |
| Pol | There are still 2 things that are really problematic in Nix with PHP. | 07:53:42 |
| Pol | And I can't do anything about it | 07:53:48 |
| Pol |
- https://github.com/NixOS/nixpkgs/pull/157287
- https://github.com/NixOS/nixpkgs/issues/154774
| 07:54:22 |
| Pol | It would be so nice to push these 2 issues. | 07:54:32 |
| Pol | The first one prevent me to use infection/infection locally. As it needs XDebug, it fails because of all the warnings. | 07:54:58 |
| Pol | The second one also need some care, but I don't know where or how to start. | 07:55:19 |
| etu | Writing a test | 07:55:30 |
| Pol | I don't really know, if you could give it some love or at least explain a bit how to do, I might have a look at some point. | 07:56:21 |
| etu | Here's the tests file for php: https://github.com/NixOS/nixpkgs/blob/master/nixos/tests/php/default.nix | 07:58:30 |
| etu | Where we include the tests | 07:58:34 |
| etu | They are then declared for each PHP version in the all tests file: https://github.com/NixOS/nixpkgs/blob/master/nixos/tests/all-tests.nix#L420-L423 | 07:59:09 |
| etu | So we run all tests as each version | 07:59:17 |
| etu | So it launches a NixOS VM and sets up services or runs commands and all that, then we can curl the VM to check if things works as expected | 07:59:57 |
| Pol | mmh mmh, thanks, will have a look as soon as I have some time. | 08:01:03 |
| Pol | If you have an idea on how to write the test, please let me know. | 08:01:16 |
| etu | We also have this hack to pass through the "right version" of the tests to each PHP package: https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/interpreters/php/generic.nix#L155 | 08:01:49 |
| etu | So you can build php81.tests to eval the tests with php81 | 08:02:19 |
