Disko evaluation seems to be broken on darwin. :/ Ran into this while testing my workshops example on darwin, but seems easy to reproduce. Just run nix flake check on darwin on diskos master (nix 2.18 and 2.23 both seem to show the same symptoms

❯ nix flake check
error:
       … while checking flake output 'nixosConfigurations'

         at /nix/store/3rj6vrlb75cd0fcrpv3ch84cqim94g87-source/flake.nix:75:7:

           74|
           75|       nixosConfigurations.testmachine = lib.nixosSystem {
             |       ^
           76|         system = "x86_64-linux";

       … while checking the NixOS configuration 'nixosConfigurations.testmachine'

         at /nix/store/3rj6vrlb75cd0fcrpv3ch84cqim94g87-source/flake.nix:75:7:

           74|
           75|       nixosConfigurations.testmachine = lib.nixosSystem {
             |       ^
           76|         system = "x86_64-linux";

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: invalid regular expression ''

       at «none»:0: (source not available)

In reply to @sylvie:karp.lol
what I had hoped to get out of disko was mostly declaratively defined zfs datasets, that I can just create by adding them to my config, but it seems I was wrong and that isn't a thing.

In reply to @sylvie:karp.lol
what I had hoped to get out of disko was mostly declaratively defined zfs datasets, that I can just create by adding them to my config, but it seems I was wrong and that isn't a thing.

Yes, it's just for initial setup by default.

If you feel adventurous and have a tested backup of your data you can try rerunning the system.build.formatScript which should be idempotent but please review the script and don't blame us if it eats your data 😇

If you want to start out with your own module and just need a solution specifically to add zfs datasets, it might be helpful to know about

nixosConfigurations.$hostname.config.disko.devices.zpool.$poolname.datasets."$dataset"._create which gives you the command diskos formatScript would use to create the dataset. That's already idempotent. Sylvie (she/it) 🏳️‍⚧️

In reply to @phaer:matrix.org

Yes, it's just for initial setup by default.

If you feel adventurous and have a tested backup of your data you can try rerunning the system.build.formatScript which should be idempotent but please review the script and don't blame us if it eats your data 😇

fileSystems."/nix" = {
	device = "/persist/nix";
	fsType = "none";
	options = [ "bind" ];
	depends = [ "/persist" ];
	neededForBoot = true;
};

fileSystems."/nix" = {
	device = "/persist/nix";
	fsType = "none";
	options = [ "bind" ];
	depends = [ "/persist" ];
	neededForBoot = true;
};