| 17 Sep 2024 |
 matthewcroughan | In reply to @enzime:nixos.dev
I should’ve used mkRenamedOption oops I forgot Not worth it atm given how disko has few users | 17:33:33 |
| matthewcroughan | Now that it has its own module, a future refactor in months time should | 17:34:13 |
|  Tom (deprecated) joined the room. | 21:04:24 |
| 18 Sep 2024 |
|  (lambda (f l) (format nil "~a ~a")) "Artur" "Manuel" changed their profile picture. | 23:00:32 |
| 19 Sep 2024 |
| matthewcroughan | Enzime: | 09:18:57 |
| matthewcroughan | 
Download image.png | 09:18:58 |
| matthewcroughan | on our DMs | 09:18:59 |
| matthewcroughan | can't accept your new request | 09:19:06 |
| matthewcroughan | tried to make a new room as a result, accept that :D | 09:19:23 |
| 20 Sep 2024 |
 mannp ⚡️ | Hi all. I am trying to add a /storage ssd to my existing disko system and have done a dry run and edited the output script to just format and mount the additional ssd only. This works fine, but when I add the same config to the full system, it won't boot due to the additional storage drive 😕 I have fileSystems."/storage".neededForBoot = false; but it still won't boot.....any possible reasons why, or things to check? thanks | 12:19:22 |
| mannp ⚡️ | I tried previously and fried my main drive and installed it all from scratch...that boots and works with the additional storage file fine, with the same config.... | 12:20:24 |
| mannp ⚡️ | * I tried previously and fried my main drive and installed it all from scratch...that boots and works with the additional storage ssd fine, with the same config.... | 12:20:47 |
| mannp ⚡️ | * I tried previously (on an identical system) and fried my main drive and installed it all from scratch...that boots and works with the additional storage ssd fine, with the same config.... | 12:21:53 |
 Mic92 | mannp ⚡️: are you missing block device drivers in your hardware-configuration.nix? | 13:42:43 |
| mannp ⚡️ left the room. | 15:34:44 |
| Mic92 | also try nofail for debugging: https://github.com/Mic92/dotfiles/blob/5f4c782602e2f7ac89237fee62a874caba0a15cc/machines/turingmachine/modules/disko.nix#L17 | 13:43:26 |
| 21 Sep 2024 |
| matthewcroughan | Mic92: https://github.com/nix-community/disko/pull/465#issuecomment-2365230543 | 15:40:28 |
| matthewcroughan | what do you mean by "more accurate algorithm", what is currently inaccurate about it? | 15:40:39 |
| matthewcroughan | The PR works well, and functions correctly, it doesn't have any bugs that I'm aware of that cause invalid outputs (disk images that don't work) | 15:41:04 |
| Mic92 | Have you looked at the disk calculation that make-disk-image does? | 15:41:41 |
| Mic92 | It's way more than just using the closure size. | 15:41:52 |
| matthewcroughan | make-disk-image doesn't do calculation? It just asks you for an imageSize right now, doesn't it? | 15:42:16 |
| matthewcroughan | or do you mean in my PR? | 15:42:48 |
| Mic92 | I mean the implementation in nixpkgs | 15:43:25 |
| Mic92 | It's ext4 only afaik | 15:43:31 |
| matthewcroughan | what does that have to do with disko? | 15:43:33 |
| Mic92 | https://github.com/NixOS/nixpkgs/blob/636c5a8db5eb31a9ce04d0e75779ab684b0f8ae3/nixos/lib/make-disk-image.nix#L453 | 15:43:57 |
| matthewcroughan | ah okay so make-disk-image from nixpkgs has a complex thing, and my thing is too simple | 15:44:50 |
| matthewcroughan | and just using the path-info size is wrong in some way? | 15:45:01 |
| Mic92 | It's just the raw content and doesn't take into account that filesystem need more data structures for inodes and stuff. | 15:45:31 |
