| 16 Sep 2024 |
 matthewcroughan @ 39c3 (DECT 94667 or 97340 or 67192) | error:
… in the condition of the assert statement
at /nix/store/l3amk5lsakpc93him5kry24kax23sn4h-source/lib/customisation.nix:365:17:
364| in commonAttrs // {
365| drvPath = assert condition; drv.drvPath;
| ^
366| outPath = assert condition; drv.outPath;
… while calling the 'seq' builtin
at /nix/store/l3amk5lsakpc93him5kry24kax23sn4h-source/lib/customisation.nix:80:32:
79| newDrv = derivation (drv.drvAttrs // (f drv));
80| in flip (extendDerivation (seq drv.drvPath true)) newDrv (
| ^
81| { meta = drv.meta or {};
(stack trace truncated; use '--show-trace' to show the full, detailed trace)
error: attribute 'diskoScript' missing
at /nix/store/w4k2mviwfgnqf7bpq3j725b4wghgc2yx-source/lib/make-disk-image.nix:81:7:
80| ''}
81| ${systemToInstall.config.system.build.diskoScript}
| ^
82| '';
| 17:10:10 |
| matthewcroughan @ 39c3 (DECT 94667 or 97340 or 67192) | Maybe due to refactors lately? Enzime | 17:10:21 |
| matthewcroughan @ 39c3 (DECT 94667 or 97340 or 67192) | This happens by accessing config.system.build.diskoImages | 17:12:41 |
| matthewcroughan @ 39c3 (DECT 94667 or 97340 or 67192) | Ah was it changed to diskoImagesScript now? | 17:13:21 |
| matthewcroughan @ 39c3 (DECT 94667 or 97340 or 67192) | Oooh it's because I didn't import my disko.nix, but this wasn't caught by the module system | 17:16:06 |
| matthewcroughan @ 39c3 (DECT 94667 or 97340 or 67192) | Odd how the diskoImages attribute still gets made | 17:16:16 |
|  silentlurker joined the room. | 20:02:34 |
| 17 Sep 2024 |
|  vandycarlos joined the room. | 01:25:44 |
 Enzime | In reply to @matthewcroughan:defenestrate.it
Odd how the diskoImages attribute still gets made fixed here https://github.com/nix-community/disko/pull/776 :) | 02:03:57 |
| Enzime | Mic92 lassulus what's the difference between merging with the GitHub UI and using mergify queue? should I prefer one or the other? | 03:27:13 |
 Mic92 | @enzime:nixos.dev: mergify builds pull requests with the latest master and merges after ci succeeds. So master should be always green doing this minus flaky tests. That's why this is our preferred merge method. | 04:46:07 |
 lassulus | Sometimes it's easier to press the button if everything is already green | 06:20:08 |
 magic_rb | If you do that you can still end up with a broken master after the merge | 06:51:04 |
 phaer | true, but unlikely for i.e. documentation-only merges :) | 11:52:12 |
| Mic92 | lassulus: always these lazy smart-phone merges. | 12:24:36 |
| lassulus changed their profile picture. | 14:38:22 |
| matthewcroughan @ 39c3 (DECT 94667 or 97340 or 67192) | Enzime: since disko is the wild west there are no crumbs to figure out where extraPostVM went | 15:30:25 |
| matthewcroughan @ 39c3 (DECT 94667 or 97340 or 67192) | the image builder has been made into its own module now which is fine and overdue, but what is the module name now? | 15:30:55 |
| matthewcroughan @ 39c3 (DECT 94667 or 97340 or 67192) | Since there is no documentation I'm reading the code instead, | 15:31:20 |
| matthewcroughan @ 39c3 (DECT 94667 or 97340 or 67192) | * Since there is no documentation I'm reading the code instead | 15:31:21 |
| matthewcroughan @ 39c3 (DECT 94667 or 97340 or 67192) | Ah okay disko.imageBuilder now, yes this is waaay overdue and something I wanted to do, thank you for doing it | 15:31:36 |
| Enzime | In reply to @matthewcroughan:defenestrate.it
Enzime: since disko is the wild west there are no crumbs to figure out where extraPostVM went I should’ve used mkRenamedOption oops I forgot | 16:16:28 |
| Enzime | one benefit of this refactor is that you can easily access the interactive VM’s base images with config.virtualisation.vmVariantWithDisko.system.build.diskoImages | 16:19:29 |
| Enzime | I’m not sure if it’s actually useful but it’s accessible | 16:19:51 |
| matthewcroughan @ 39c3 (DECT 94667 or 97340 or 67192) | Enzime: I'm not sure what the correct way to do this that would make mic/lassulus happy is https://github.com/nix-community/disko/pull/465 | 16:44:59 |
| matthewcroughan @ 39c3 (DECT 94667 or 97340 or 67192) | But if you have any time to make it work, I would really appreciate it | 16:45:08 |
| matthewcroughan @ 39c3 (DECT 94667 or 97340 or 67192) | shouldn't be too hard, the implementation is correct, but in terms of putting it into the module system, catching errors, reporting to user by builtins.trace etc, that's what I don't know how to do yet | 16:45:36 |
| matthewcroughan @ 39c3 (DECT 94667 or 97340 or 67192) | In reply to @enzime:nixos.dev
I should’ve used mkRenamedOption oops I forgot Not worth it atm given how disko has few users | 17:33:33 |
| matthewcroughan @ 39c3 (DECT 94667 or 97340 or 67192) | Now that it has its own module, a future refactor in months time should | 17:34:13 |
|  Tom (deprecated) joined the room. | 21:04:24 |
