!oNSIfazDqEcwhcOjSL:matrix.org

disko

367 Members
disko - declarative disk partitioning - https://github.com/nix-community/disko94 Servers

Load older messages


SenderMessageTime
4 Apr 2024
@lassulus:lassul.uslassulusyeah thats a way to do it16:10:28
5 Apr 2024
@soispha:vhack.euBenedikt joined the room.04:23:38
6 Apr 2024
@hoskellisiera:matrix.orghoskellisieraHey, is there a way to use disko on the config.system.build.vm Attribute in a testflake?19:25:20
@hoskellisiera:matrix.orghoskellisiera * Hey, is there a way to use disko on the config.system.build.vm Attribute in a testflake? 19:25:31
@lassulus:lassul.uslassuluswhat do you want to do?19:33:40
@lassulus:lassul.uslassulusthere is sadly no way to have your disk configuration in the nixos generated vm config19:33:57
@matthewcroughan:defenestrate.itmatthewcroughan lassulus: does config.system.build.vm not have extendModules ? 19:38:13
@matthewcroughan:defenestrate.itmatthewcroughanoh yeah looks like it might now 19:38:41
@matthewcroughan:defenestrate.itmatthewcroughan * oh yeah looks like it might not19:38:44
@matthewcroughan:defenestrate.itmatthewcroughan would be cool to put that in passtrhu 19:38:56
@matthewcroughan:defenestrate.itmatthewcroughan * would be cool to put that in passthru 19:38:59
@hoskellisiera:matrix.orghoskellisiera
In reply to @lassulus:lassul.us
there is sadly no way to have your disk configuration in the nixos generated vm config
that's what I wanted to do
19:52:13
7 Apr 2024
@perchun:matrix.orgPerchun Pak Btw, I don't know if it is intended, but this command returns exit code 0 when partition exists
https://github.com/nix-community/disko/blob/0a17298c0d96190ef3be729d594ba202b9c53beb/lib/types/gpt.nix#L158
Should I open an issue on GitHub?
10:00:59
@lassulus:lassul.uslassulushmm, what is the problem?10:02:55
@lassulus:lassul.uslassulusah maybe an ! is missing10:04:51
@lassulus:lassul.uslassulusbut not sure how it even gets to that point, since it will skip the whole if statement if a table exists on line 15610:06:21
@perchun:matrix.orgPerchun Pak I am not familiar with the code, but this line has 3 possible states (from my understanding)
- partition table does not exist
- partition does not exist
- partition exists

In bottom two sgdisk exits with 0 code, but in first with some other (don't remember exactly). Though if partition table doesn't exist, it will be created on top of the script
10:06:40
@lassulus:lassul.uslassulusbut not sure there is a scenario where a partition table does not exist but a partition?10:07:33
@lassulus:lassul.uslassuluseither way, the code doesn't do whats intended :)10:07:46
@perchun:matrix.orgPerchun Pak
In reply to @lassulus:lassul.us
but not sure how it even gets to that point, since it will skip the whole if statement if a table exists on line 156
I deleted the part that created the partition table, that's how it did for me

So if the scenario where sgdisk exits with non zero doesn't exist, why is there an if statement?
10:08:26
@perchun:matrix.orgPerchun Pak
In reply to @lassulus:lassul.us
but not sure how it even gets to that point, since it will skip the whole if statement if a table exists on line 156
* I deleted the part that created the partition table, that's how it did for me (not saying you should support this use case)

So if the scenario where sgdisk exits with non zero doesn't exist, why is there an if statement?
10:09:07
@lassulus:lassul.uslassuluswell I wanted to create it in the case where the table exists but the partition does not10:11:55
@lassulus:lassul.uslassulusI will prepare a commit10:12:02
@lassulus:lassul.uslassulusgive me 5min10:12:04
@perchun:matrix.orgPerchun Pak I already did everything with my disk, it is not a blocker for me 10:12:38
@perchun:matrix.orgPerchun Pak * I already did everything with my disk, it is not a problem for me 10:12:47
@perchun:matrix.orgPerchun Pak Just a thing I noticed  10:12:59
@xxxcrow:matrix.orgn3v3r_a9a1nhalo! has anyone achieved disko + nixos-anywhere + impermanence btrfs? (+sops) 10:13:01
@perchun:matrix.orgPerchun Pak
In reply to @xxxcrow:matrix.org
halo!
has anyone achieved disko + nixos-anywhere + impermanence btrfs? (+sops)
Vimjoyer did config for btrfs + impermanence, don't know about other things 
https://youtu.be/YPKwkWtK7l0?feature=shared
10:14:30
@lassulus:lassul.uslassulushmm, indeed weird, that sgdisk exists with 0 on an error10:20:57

Show newer messages


Back to Room ListRoom Version: 10