| 4 Apr 2024 |
lassulus | yeah thats a way to do it | 16:10:28 |
| 5 Apr 2024 |
| Benedikt joined the room. | 04:23:38 |
| 6 Apr 2024 |
hoskellisiera | Hey, is there a way to use disko on the config.system.build.vm Attribute in a testflake? | 19:25:20 |
hoskellisiera | * Hey, is there a way to use disko on the config.system.build.vm Attribute in a testflake? | 19:25:31 |
lassulus | what do you want to do? | 19:33:40 |
lassulus | there is sadly no way to have your disk configuration in the nixos generated vm config | 19:33:57 |
matthewcroughan | lassulus: does config.system.build.vm not have extendModules ? | 19:38:13 |
matthewcroughan | oh yeah looks like it might now | 19:38:41 |
matthewcroughan | * oh yeah looks like it might not | 19:38:44 |
matthewcroughan | would be cool to put that in passtrhu | 19:38:56 |
matthewcroughan | * would be cool to put that in passthru | 19:38:59 |
hoskellisiera | In reply to @lassulus:lassul.us there is sadly no way to have your disk configuration in the nixos generated vm config that's what I wanted to do | 19:52:13 |
| 7 Apr 2024 |
Perchun Pak | Btw, I don't know if it is intended, but this command returns exit code 0 when partition exists https://github.com/nix-community/disko/blob/0a17298c0d96190ef3be729d594ba202b9c53beb/lib/types/gpt.nix#L158 Should I open an issue on GitHub? | 10:00:59 |
lassulus | hmm, what is the problem? | 10:02:55 |
lassulus | ah maybe an ! is missing | 10:04:51 |
lassulus | but not sure how it even gets to that point, since it will skip the whole if statement if a table exists on line 156 | 10:06:21 |
Perchun Pak | I am not familiar with the code, but this line has 3 possible states (from my understanding) - partition table does not exist - partition does not exist - partition exists
In bottom two sgdisk exits with 0 code, but in first with some other (don't remember exactly). Though if partition table doesn't exist, it will be created on top of the script | 10:06:40 |
lassulus | but not sure there is a scenario where a partition table does not exist but a partition? | 10:07:33 |
lassulus | either way, the code doesn't do whats intended :) | 10:07:46 |
Perchun Pak | In reply to @lassulus:lassul.us but not sure how it even gets to that point, since it will skip the whole if statement if a table exists on line 156 I deleted the part that created the partition table, that's how it did for me
So if the scenario where sgdisk exits with non zero doesn't exist, why is there an if statement? | 10:08:26 |
Perchun Pak | In reply to @lassulus:lassul.us but not sure how it even gets to that point, since it will skip the whole if statement if a table exists on line 156 * I deleted the part that created the partition table, that's how it did for me (not saying you should support this use case)
So if the scenario where sgdisk exits with non zero doesn't exist, why is there an if statement? | 10:09:07 |
lassulus | well I wanted to create it in the case where the table exists but the partition does not | 10:11:55 |
lassulus | I will prepare a commit | 10:12:02 |
lassulus | give me 5min | 10:12:04 |
Perchun Pak | I already did everything with my disk, it is not a blocker for me | 10:12:38 |
Perchun Pak | * I already did everything with my disk, it is not a problem for me | 10:12:47 |
Perchun Pak | Just a thing I noticed | 10:12:59 |
n3v3r_a9a1n | halo!
has anyone achieved disko + nixos-anywhere + impermanence btrfs? (+sops) | 10:13:01 |
Perchun Pak | In reply to @xxxcrow:matrix.org halo! has anyone achieved disko + nixos-anywhere + impermanence btrfs? (+sops) Vimjoyer did config for btrfs + impermanence, don't know about other things https://youtu.be/YPKwkWtK7l0?feature=shared | 10:14:30 |
lassulus | hmm, indeed weird, that sgdisk exists with 0 on an error | 10:20:57 |