| 3 Jan 2025 |
 guiniol | Hi all! I am trying to use disko to setup a ZFS pool, and it seems that the code creating the partitions is not giving them the partlabels that the code that's creating the pool expects: | 22:06:11 |
| guiniol | not all disks accounted for, skipping creating zpool znas
++ echo '/dev/disk/by-partlabel/disk-samsung_pm863a_s2tynx0k401843-zfs
/dev/disk/by-partlabel/disk-samsung_pm863a_s2tynx0k602434-zfs
/dev/disk/by-partlabel/disk-samsung_pm863a_s2tynx0m101514-zfs
/dev/disk/by-partlabel/disk-samsung_pm863a_s2tynx0m104200-zfs
/dev/disk/by-partlabel/disk-samsung_pm863a_s2tynx0m105690-zfs
/dev/disk/by-partlabel/disk-samsung_pm863a_s2tynx0m105696-zfs'
+ diff /dev/fd/63 /dev/fd/62
++ echo '/dev/disk/by-partlabel/087ae77a63bca70cf4e6cc400ae75807f9f2
/dev/disk/by-partlabel/8aaf2c7c984564bdb7e0011e422c6a18c2a2
/dev/disk/by-partlabel/8c50307ad89c89315f46d48e8cffd1d8fe57
/dev/disk/by-partlabel/9302577e1d192ebb8ee6d1ed80cd11999356
/dev/disk/by-partlabel/c97a99017e1be9178a666ae8fe0f078f7f9e
/dev/disk/by-partlabel/e0b29d880c5fe44a941fc7c68948ec1c4c12'
1,6c1,6
< /dev/disk/by-partlabel/disk-samsung_pm863a_s2tynx0k401843-zfs
< /dev/disk/by-partlabel/disk-samsung_pm863a_s2tynx0k602434-zfs
< /dev/disk/by-partlabel/disk-samsung_pm863a_s2tynx0m101514-zfs
< /dev/disk/by-partlabel/disk-samsung_pm863a_s2tynx0m104200-zfs
< /dev/disk/by-partlabel/disk-samsung_pm863a_s2tynx0m105690-zfs
< /dev/disk/by-partlabel/disk-samsung_pm863a_s2tynx0m105696-zfs
---
> /dev/disk/by-partlabel/087ae77a63bca70cf4e6cc400ae75807f9f2
> /dev/disk/by-partlabel/8aaf2c7c984564bdb7e0011e422c6a18c2a2
> /dev/disk/by-partlabel/8c50307ad89c89315f46d48e8cffd1d8fe57
> /dev/disk/by-partlabel/9302577e1d192ebb8ee6d1ed80cd11999356
> /dev/disk/by-partlabel/c97a99017e1be9178a666ae8fe0f078f7f9e
> /dev/disk/by-partlabel/e0b29d880c5fe44a941fc7c68948ec1c4c12```
| 22:06:20 |
| guiniol | What am I doing wrong? I checked the members in my vdevs are indeed the right disks | 22:06:56 |
| guiniol | I couldn't quite find the part that creates the partlabels (the part that expects them is here: https://github.com/nix-community/disko/blob/84a5b93637cc16cbfcc61b6e1684d626df61eb21/lib/types/zpool.nix#L238C1-L238C109) | 22:08:37 |
| guiniol | nevermind, I found it: https://github.com/nix-community/disko/blob/84a5b93637cc16cbfcc61b6e1684d626df61eb21/lib/types/gpt.nix#L87 | 22:19:23 |
| guiniol | so, my names were too long and hashed instead of used as is, except no one told the code in zpool.nix | 22:19:47 |
| guiniol | I'll open an issue | 22:19:52 |
