| 17 Sep 2024 |
 Mic92 | @enzime:nixos.dev: mergify builds pull requests with the latest master and merges after ci succeeds. So master should be always green doing this minus flaky tests. That's why this is our preferred merge method. | 04:46:07 |
 lassulus | Sometimes it's easier to press the button if everything is already green | 06:20:08 |
 magic_rb | If you do that you can still end up with a broken master after the merge | 06:51:04 |
 phaer | true, but unlikely for i.e. documentation-only merges :) | 11:52:12 |
| Mic92 | lassulus: always these lazy smart-phone merges. | 12:24:36 |
| lassulus changed their profile picture. | 14:38:22 |
 matthewcroughan | Enzime: since disko is the wild west there are no crumbs to figure out where extraPostVM went | 15:30:25 |
| matthewcroughan | the image builder has been made into its own module now which is fine and overdue, but what is the module name now? | 15:30:55 |
| matthewcroughan | Since there is no documentation I'm reading the code instead, | 15:31:20 |
| matthewcroughan | * Since there is no documentation I'm reading the code instead | 15:31:21 |
| matthewcroughan | Ah okay disko.imageBuilder now, yes this is waaay overdue and something I wanted to do, thank you for doing it | 15:31:36 |
 Enzime | In reply to @matthewcroughan:defenestrate.it
Enzime: since disko is the wild west there are no crumbs to figure out where extraPostVM went I should’ve used mkRenamedOption oops I forgot | 16:16:28 |
| Enzime | one benefit of this refactor is that you can easily access the interactive VM’s base images with config.virtualisation.vmVariantWithDisko.system.build.diskoImages | 16:19:29 |
| Enzime | I’m not sure if it’s actually useful but it’s accessible | 16:19:51 |
| matthewcroughan | Enzime: I'm not sure what the correct way to do this that would make mic/lassulus happy is https://github.com/nix-community/disko/pull/465 | 16:44:59 |
| matthewcroughan | But if you have any time to make it work, I would really appreciate it | 16:45:08 |
| matthewcroughan | shouldn't be too hard, the implementation is correct, but in terms of putting it into the module system, catching errors, reporting to user by builtins.trace etc, that's what I don't know how to do yet | 16:45:36 |
| matthewcroughan | In reply to @enzime:nixos.dev
I should’ve used mkRenamedOption oops I forgot Not worth it atm given how disko has few users | 17:33:33 |
| matthewcroughan | Now that it has its own module, a future refactor in months time should | 17:34:13 |
|  Tom (deprecated) joined the room. | 21:04:24 |
| 18 Sep 2024 |
|  (artur 'manuel) changed their profile picture. | 23:00:32 |
| 19 Sep 2024 |
| matthewcroughan | Enzime: | 09:18:57 |
| matthewcroughan | 
Download image.png | 09:18:58 |
| matthewcroughan | on our DMs | 09:18:59 |
| matthewcroughan | can't accept your new request | 09:19:06 |
| matthewcroughan | tried to make a new room as a result, accept that :D | 09:19:23 |
| 20 Sep 2024 |
 mannp ⚡️ | Hi all. I am trying to add a /storage ssd to my existing disko system and have done a dry run and edited the output script to just format and mount the additional ssd only. This works fine, but when I add the same config to the full system, it won't boot due to the additional storage drive 😕 I have fileSystems."/storage".neededForBoot = false; but it still won't boot.....any possible reasons why, or things to check? thanks | 12:19:22 |
| mannp ⚡️ | I tried previously and fried my main drive and installed it all from scratch...that boots and works with the additional storage file fine, with the same config.... | 12:20:24 |
| mannp ⚡️ | * I tried previously and fried my main drive and installed it all from scratch...that boots and works with the additional storage ssd fine, with the same config.... | 12:20:47 |
| mannp ⚡️ | * I tried previously (on an identical system) and fried my main drive and installed it all from scratch...that boots and works with the additional storage ssd fine, with the same config.... | 12:21:53 |
