| 25 Nov 2023 |
 ners | In reply to @mfrischknecht:matrix.org
ners: I thought only committers can tag issues? It's not really a tag, it's just a bit of text to put in the PR description. | 15:30:05 |
| ners | In reply to @mfrischknecht:matrix.org
ners: I thought only committers can tag issues? * It's not really a tag, it's just a bit of text to put in the PR description.
Example: https://github.com/NixOS/nixpkgs/pull/269862 | 15:30:21 |
 mfrischknecht | @ners okay, thanks | 15:31:14 |
 Jonas Chevalier | https://www.debian.org/ | 15:33:59 |
| mfrischknecht | infinisil: If you still have the time and nerves to explain some Nixkpgs testing black magic, I've stumbled over a curious case. (Curious in how it works in Nix, not something unholy like the last one) | 15:34:44 |
| mfrischknecht | ...I thought I leave it open to you :) I'm looking through the other candidates unless you're up for another Odyssey | 15:36:44 |
 nebucatnetzer13 | How do I create a proper patch to use in Nix? | 15:57:52 |
 zopieux | $ git clone <source>
$ vim ...
$ git diff --output path/to/nixpkgs/.../mypatch.patch
| 16:02:17 |
 infinisil | https://github.com/NixOS/nixpkgs/tree/master/pkgs#patches | 16:05:10 |
 sdier | oof as I watch my poor Mac mini at home build 1605 packages as part of running nixpkgs-review | 16:09:47 |
| sdier | oh I think it only needs to build 835 | 16:18:54 |
 Joshua | https://hydra.nixos.org/build/241775011 | 16:23:35 |
| nebucatnetzer13 | This MR would require labels. However the package doesn't run properly after compiling: https://github.com/NixOS/nixpkgs/pull/269934 | 16:39:33 |
 Auguste Baum | In reply to @augustebaum:matrix.org
Looking at wasmer-python Fixed in https://github.com/NixOS/nixpkgs/pull/269948 ! Can someone with the appropriate rights label and merge this? | 17:40:26 |
 fricklerhandwerk | Jonas Chevalier Elton Vecchietti We‘re at Paragraph 11 from 20:00 | 18:47:24 |
 Ivan Mincik (imincik) | https://github.com/NixOS/nixpkgs/pull/269954 | 23:14:04 |
| Ivan Mincik (imincik) | https://github.com/NixOS/nixpkgs/pull/269937 | 23:14:24 |
| 26 Nov 2023 |
| mfrischknecht | infinisil: https://github.com/NixOS/nixpkgs/pull/270101
...is there something more I should put in there for removing the fix later on (as there's already a fix upstream, but no releases yet; also: Nixpkgs are already behind a couple of releases)?
| 10:35:21 |
| mfrischknecht | infinisil: Changed the osquery PR as discussed. | 11:36:49 |
 @delroth:delroth.net | I was going to suggest applying the upstream patch as well :) | 11:37:04 |
| mfrischknecht | CC delroth I see you already tagged it :) | 11:37:05 |
| @delroth:delroth.net | mfrischknecht: can you fix the PR description? | 11:37:39 |
| mfrischknecht | Ah, you mean
Switches osquery build to LLVM 15 until the upstream fix has been released.
right?
| 11:38:33 |
| mfrischknecht | * Ah, you mean
Switches osquery build to LLVM 15 until the upstream fix has been released.
right?
| 11:38:42 |
| mfrischknecht | * Ah, you mean
Switches osquery build to LLVM 15 until the upstream fix has been released.
right?
| 11:38:49 |
| mfrischknecht | I think the rest is still applicable | 11:38:59 |
| @delroth:delroth.net | right, and I'd also change the part about the unreleased fix to more clearly explain that you cherry-picked that patch | 11:39:24 |
| mfrischknecht | Sure, one sec :) | 11:39:43 |
| mfrischknecht | delroth:
There already is an upstream patch for this [1], but it hasn't been released yet.
[1]: osquery/osquery@222991a
[...]
Fetch and apply the unreleased upstream patch during nix builds. This should be revertible as soon as upstream releases the patch and the new version is packaged.
Sound good?
| 11:43:08 |
| @delroth:delroth.net | SGTM | 11:45:27 |
